[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-26 Thread Brett Cannon
Brett Cannon added the comment: If you can't find the guidance then please either open an issue or submit a PR to update the devguide with the info. As for why your other PR was accepted, that was fixing an actual bug in the docstring. This one has absolutely no semantic change to Python; it

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-25 Thread Ram Rachum
Ram Rachum added the comment: Brett: Oh well, I understand. Looking at the devguide, I can't find where this is written. I'm interested in seeing how it's phrased, because I do think that tiny, incremental changes are important. I would want to know why, for example, my change https://github

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-25 Thread Brett Cannon
Brett Cannon added the comment: > Is this an axiom or is the reasoning written down somewhere? It should be written down in the devguide at devguide.python.org. I agree with Serhiy that this isn't really adding anything by making the code that much more readable, idiomatic, or faster to warr

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Similar cleanup (and many many others) was proposed when pathlib was initially added to the stdlib. They were rejected, so now we need a new discussion to revise the old decision. See issue20002. -- ___ Python t

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-24 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-24 Thread Ram Rachum
Change by Ram Rachum : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-24 Thread Ram Rachum
Ram Rachum added the comment: "We usually do not accept such pure cosmetic changes." Is this an axiom or is the reasoning written down somewhere? I'd think we all like to remove cruft that's no longer necessary. -- ___ Python tracker

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This code is valid in Python 3. We usually do not accept such pure cosmetic changes. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-24 Thread Ram Rachum
Change by Ram Rachum : -- keywords: +patch pull_requests: +19612 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20349 ___ Python tracker ___ _

[issue40753] Remove Python 2 compatibility code from pathlib

2020-05-24 Thread Ram Rachum
New submission from Ram Rachum : No need to inherit from object. I'm writing the patch now. -- components: Library (Lib) messages: 369770 nosy: cool-RR priority: normal severity: normal status: open title: Remove Python 2 compatibility code from pathlib type: enhancement versions: Pytho