[issue40335] Regression in multiline SyntaxError offsets

Anthony Sottile added the comment: cool, reported there as well! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue40335] Regression in multiline SyntaxError offsets

Pablo Galindo Salgado added the comment: > pyflakes's testsuite has many failures under the new parser Can you report this also on the PEP 617 issue? -- ___ Python tracker __

[issue40335] Regression in multiline SyntaxError offsets

Anthony Sottile added the comment: pyflakes's testsuite has many failures under the new parser -- is the expectation that those will be fixed by 3.9 final? -- ___ Python tracker

[issue40335] Regression in multiline SyntaxError offsets

Pablo Galindo Salgado added the comment: And the regression happens because we are ignoring that test currently due to the new parser not currently reporting the same offsets: https://github.com/python/cpython/blob/master/Lib/test/test_exceptions.py#L181 -- _

[issue40335] Regression in multiline SyntaxError offsets

Pablo Galindo Salgado added the comment: With the old parser it works: ~/github/python/master master* ❯ ./python -X oldparser t.py 3.9.0a5+ (heads/master:503de7149d, Apr 24 2020, 22:02:28) [GCC 9.3.0] SyntaxError: - line: 8 - offset: 8 - text: "'''\n\ndef bar():\npass\n\ndef baz():\n

[issue40335] Regression in multiline SyntaxError offsets

Pablo Galindo Salgado added the comment: Yeah, I can confirm after bisecting that the commit that introduced the regression is the new parser: c5fc15685202cda73f7c3f5c6f299b0945f58508 is the first bad commit commit c5fc15685202cda73f7c3f5c6f299b0945f58508 Author: Pablo Galindo Date: Wed Ap

[issue40335] Regression in multiline SyntaxError offsets

Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg367225 ___ Python tracker ___ ___ Python-bugs-list

[issue40335] Regression in multiline SyntaxError offsets

Pablo Galindo Salgado added the comment: Hu.actually, no. This is something else... -- ___ Python tracker ___ ___ Python-bu

[issue40335] Regression in multiline SyntaxError offsets

Pablo Galindo Salgado added the comment: This is likely due to the new parser (see PEP 617). Do you get the same problem running with -X oldparser ? -- ___ Python tracker ___

[issue40335] Regression in multiline SyntaxError offsets

Anthony Sottile added the comment: This seems to have regressed again $ ./python --version --version Python 3.9.0a5+ (heads/master:503de7149d, Apr 24 2020, 13:34:49) [GCC 7.5.0] $ ./python t.py File "/home/asottile/workspace/cpython/t.py", line 8

[issue40335] Regression in multiline SyntaxError offsets

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40335] Regression in multiline SyntaxError offsets

Pablo Galindo Salgado added the comment: New changeset 11a7f158ef51b0edcde3c3d9215172354e385877 by Pablo Galindo in branch 'master': bpo-40335: Correctly handle multi-line strings in tokenize error scenarios (GH-19619) https://github.com/python/cpython/commit/11a7f158ef51b0edcde3c3d921517235

[issue40335] Regression in multiline SyntaxError offsets

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +18949 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19619 ___ Python tracker __

[issue40335] Regression in multiline SyntaxError offsets

Pablo Galindo Salgado added the comment: The regression happened in: commit 41d5b94af44e34ac05d4cd57460ed104ccf96628 Author: Lysandros Nikolaou Date: Sun Apr 12 21:21:00 2020 +0300 bpo-40246: Report a better error message for invalid string prefixes (GH-19476) Will try to get a look

[issue40335] Regression in multiline SyntaxError offsets

Change by gaborbernat : -- nosy: +gaborbernat ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue40335] Regression in multiline SyntaxError offsets

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue40335] Regression in multiline SyntaxError offsets

Change by Anthony Sottile : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue40335] Regression in multiline SyntaxError offsets

Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue40335] Regression in multiline SyntaxError offsets

New submission from Anthony Sottile : this was noticed in pyflakes's testsuite: https://github.com/PyCQA/pyflakes/pull/532#pullrequestreview-396059622 I've created a small script to reproduce the problem ``` import sys SRC = b"""\ def foo(): ''' def bar(): pass def baz(): '''qu