[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: >> Perhaps you missed it because you're not in the CODEOWNERS so don't >> automatically get notified by GitHub? > That's quite possible. I can't fix that as Github considers everything to do with my computer and browser too old. I don't think you need to use t

[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Steven D'Aprano
Steven D'Aprano added the comment: > Perhaps you missed it because you're not in the CODEOWNERS so don't > automatically get notified by GitHub? That's quite possible. I can't fix that as Github considers everything to do with my computer and browser too old. Until I can get a new computer,

[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Tal Einat
Tal Einat added the comment: Steven, the conversation happened in the GitHub PR comments. The PR went through multiple iterations of code review, by both Kyle Stanley and myself, and I even waited an extra couple of weeks to see if anyone had any more comments before merging it... Perhaps y

[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Steven D'Aprano
Steven D'Aprano added the comment: *blink* How did I miss this entire thing? Where was the code review? Thanks Tal for shepherding this through, and thanks Tzanetos for caring about the unit tests. -- ___ Python tracker

[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Tal Einat
Tal Einat added the comment: Tzanetos, thanks for the report, PR, patience iterating through several rounds of code review comments, and overall great work! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Tal Einat
Tal Einat added the comment: New changeset b809717c1ead26b4e3693b8a5505dd8f8f666f08 by Tzanetos Balitsaris in branch 'master': bpo-40331: Increase test coverage for the statistics module (GH-19608) https://github.com/python/cpython/commit/b809717c1ead26b4e3693b8a5505dd8f8f666f08 --

[issue40331] Increase test coverage for the statistics module

2020-04-19 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +steven.daprano ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40331] Increase test coverage for the statistics module

2020-04-19 Thread Tzanetos Balitsaris
Change by Tzanetos Balitsaris : -- keywords: +patch pull_requests: +18941 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19608 ___ Python tracker

[issue40331] Increase test coverage for the statistics module

2020-04-19 Thread Tzanetos Balitsaris
New submission from Tzanetos Balitsaris : The statistics module is already highly tested but it seems that there are 4 statements [0] that are not executed by the equivalent unit tests. Specifically, 3 statements which are part of the `_convert`, `_find_lteq`, and `_find_rteq` functions, and