[issue40279] Documentation example of module init function lacks error handling

Stefan Behnel added the comment: New changeset 882a7f44da08c6fb210bd9a17f80903cbca84034 by Miss Islington (bot) in branch '3.8': bpo-40279: Add some error-handling to the module initialisation docs example (GH-19705) (GH-19710) https://github.com/python/cpython/commit/882a7f44da08c6fb210bd9a

[issue40279] Documentation example of module init function lacks error handling

Stefan Behnel added the comment: Hi Cajetan, thank you for your contribution! That's a nice documentation improvement. -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue40279] Documentation example of module init function lacks error handling

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +19031 pull_request: https://github.com/python/cpython/pull/19710 ___ Python tracker _

[issue40279] Documentation example of module init function lacks error handling

Stefan Behnel added the comment: New changeset d4f3923d5901ef1ccdbe6ad6c5a753af90832a0f by Cajetan Rodrigues in branch 'master': bpo-40279: Add some error-handling to the module initialisation docs example (GH-19705) https://github.com/python/cpython/commit/d4f3923d5901ef1ccdbe6ad6c5a753af90

[issue40279] Documentation example of module init function lacks error handling

Change by Cajetan Rodrigues : -- keywords: +patch pull_requests: +19024 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/19705 ___ Python tracker ___

[issue40279] Documentation example of module init function lacks error handling

Cajetan Rodrigues added the comment: At the risk of sounding like a jerk, I'd very much want to say that copy-pasters should get what they deserve :) But then I remember I was once a copy-paster too! Hello again, Stefan :) Thanks for watching out for the community - I'll be happy to fix thi

[issue40279] Documentation example of module init function lacks error handling

New submission from Stefan Behnel : The example in the docs that shows how to initialise an embedded module gives a wrong impression about error handling. Most of the functions that it calls return error codes, but those do not get looked at. Innocent users who copy and paste the example may