[issue39890] The AST is mangled when compiling starred assignments

2020-03-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset d5aa2e941ccc44412b95d0e3f0a1789fbcccf403 by Brandt Bucher in branch 'master': bpo-39890: Don't mutate the AST when compiling starred assignments (GH-18833) https://github.com/python/cpython/commit/d5aa2e941ccc44412b95d0e3f0a1789fbcccf403

[issue39890] The AST is mangled when compiling starred assignments

2020-03-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks for the great catch, Brandt! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39890] The AST is mangled when compiling starred assignments

2020-03-07 Thread Brandt Bucher
Change by Brandt Bucher : -- title: The AST is mangled when compiling starred assignments. -> The AST is mangled when compiling starred assignments ___ Python tracker ___

[issue39890] The AST is mangled when compiling starred assignments.

2020-03-07 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +18190 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18833 ___ Python tracker ___ __

[issue39890] The AST is mangled when compiling starred assignments.

2020-03-07 Thread Brandt Bucher
New submission from Brandt Bucher : It looks like assignment_helper is the only place where we actually change the semantic meaning of the AST during compilation (a starred name is changed to a regular name as a shortcut). This probably isn't a great idea, and it would bite us later if we sta