[issue39684] PyUnicode_IsIdentifier has two if/thens that can be combined

Benjamin Peterson added the comment: New changeset 933fc53f3f9c64ffa703b1f23a93bec560faea57 by Andy Lester in branch 'master': closes bpo-39684: Combine two if/thens and squash uninit var warning. (GH-18565) https://github.com/python/cpython/commit/933fc53f3f9c64ffa703b1f23a93bec560faea57 -

[issue39684] PyUnicode_IsIdentifier has two if/thens that can be combined

Change by Andy Lester : -- pull_requests: -17937 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue39684] PyUnicode_IsIdentifier has two if/thens that can be combined

Change by Andy Lester : -- pull_requests: +17947 pull_request: https://github.com/python/cpython/pull/18565 ___ Python tracker ___ _

[issue39684] PyUnicode_IsIdentifier has two if/thens that can be combined

Change by Andy Lester : -- keywords: +patch pull_requests: +17937 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18557 ___ Python tracker ___

[issue39684] PyUnicode_IsIdentifier has two if/thens that can be combined

New submission from Andy Lester : These two code if/thens can be combined if (ready) { kind = PyUnicode_KIND(self); data = PyUnicode_DATA(self); } else { wstr = _PyUnicode_WSTR(self); } Py_UCS4 ch; if (ready) { ch = PyUnicode_READ(kind, d