[issue39677] 3.6+ documentation for MAKE_FUNCTION

Serhiy Storchaka added the comment: Sorry for the delay with review and thank you for your contribution. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.6 ___ Python tracker

[issue39677] 3.6+ documentation for MAKE_FUNCTION

miss-islington added the comment: New changeset a927e91186727b5184d774d1d99c70b9ff5497f5 by Miss Islington (bot) in branch '3.8': bpo-39677: dis: rename the operand of MAKE_FUNCTION from `argc` to `flags` for 3.6+ (GC-18550) https://github.com/python/cpython/commit/a927e91186727b5184d774d1d9

[issue39677] 3.6+ documentation for MAKE_FUNCTION

miss-islington added the comment: New changeset 725cbce25084a67ad7ff48b75cca3e240ef57606 by Miss Islington (bot) in branch '3.7': bpo-39677: dis: rename the operand of MAKE_FUNCTION from `argc` to `flags` for 3.6+ (GC-18550) https://github.com/python/cpython/commit/725cbce25084a67ad7ff48b75c

[issue39677] 3.6+ documentation for MAKE_FUNCTION

Serhiy Storchaka added the comment: New changeset 6672c16b1d7f83789bf3a2016bd19edfd3568e71 by Taine Zhao in branch 'master': bpo-39677: dis: rename the operand of MAKE_FUNCTION from `argc` to `flags` for 3.6+ (GC-18550) https://github.com/python/cpython/commit/6672c16b1d7f83789bf3a2016bd19ed

[issue39677] 3.6+ documentation for MAKE_FUNCTION

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +18340 pull_request: https://github.com/python/cpython/pull/18993 ___ Python tracker _

[issue39677] 3.6+ documentation for MAKE_FUNCTION

Change by miss-islington : -- pull_requests: +18341 pull_request: https://github.com/python/cpython/pull/18994 ___ Python tracker ___ __

[issue39677] 3.6+ documentation for MAKE_FUNCTION

Change by thautwarm : -- pull_requests: +17930 pull_request: https://github.com/python/cpython/pull/18550 ___ Python tracker ___ ___

[issue39677] 3.6+ documentation for MAKE_FUNCTION

Change by thautwarm : -- keywords: +patch pull_requests: +17929 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18549 ___ Python tracker ___

[issue39677] 3.6+ documentation for MAKE_FUNCTION

thautwarm added the comment: Okay, I'll make a PR. It's okay because users will always check docs of version 3 instead of a specific version like 3.6. -- ___ Python tracker _

[issue39677] 3.6+ documentation for MAKE_FUNCTION

Serhiy Storchaka added the comment: Agree. Do you want to provide a PR? Although it may be too later for 3.6 which only takes security fixes. -- keywords: +easy nosy: +serhiy.storchaka stage: -> needs patch versions: +Python 3.7, Python 3.8, Python 3.9 __

[issue39677] 3.6+ documentation for MAKE_FUNCTION

New submission from thautwarm : LINK: https://docs.python.org/3.6/library/dis.html?highlight=bytecode#opcode-MAKE_FUNCTION To avoid being confusing, MAKE_FUNCTION(argc) shall be MAKE_FUNCTION(flag), since 3.6 the operand of MAKE_FUNCTION never means `argcount`. -- assignee: docs@pyth