[issue39585] Delete a pending item in _warning.c

hai shi added the comment: Thanks, serhiy. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue39585] Delete a pending item in _warning.c

Serhiy Storchaka added the comment: The C code is equivalent to the Python code. No special handling is needed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue39585] Delete a pending item in _warning.c

Serhiy Storchaka added the comment: New changeset 57c781048915e45d15eaa348c51ec01b12cc170a by Hai Shi in branch 'master': bpo-39585: Delete a pending comment in _warning.c (GH-18414) https://github.com/python/cpython/commit/57c781048915e45d15eaa348c51ec01b12cc170a -- nosy: +serhiy.s

[issue39585] Delete a pending item in _warning.c

Change by hai shi : -- components: +Extension Modules -Interpreter Core ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue39585] Delete a pending item in _warning.c

hai shi added the comment: > What if a warning has a metaclass with a custom __getattribute__ method? Sorry, ppperry. I don't understand your question clearly. Could you give me some examples? This function could be touched when user call `warnings.warn_explicit()`. --

[issue39585] Delete a pending item in _warning.c

ppperry added the comment: What if a warning has a metaclass with a custom __getattribute__ method? -- nosy: +ppperry ___ Python tracker ___ __

[issue39585] Delete a pending item in _warning.c

hai shi added the comment: If I am wrong, remove the check operation of `name` is fine. -- ___ Python tracker ___ ___ Python-bugs-l

[issue39585] Delete a pending item in _warning.c

Change by hai shi : -- keywords: +patch pull_requests: +17789 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18414 ___ Python tracker ___

[issue39585] Delete a pending item in _warning.c

New submission from hai shi : a pend item could be removed (https://github.com/python/cpython/blob/master/Python/_warnings.c#L493). two reasons: 1) every warning have `__name__` and it must not NULL(`The tp_name slot must be set;` from pep0253) 2) the `__name__` of Warning class(including chi