[issue39559] uuid.getnode() has unused argument

Serhiy Storchaka added the comment: I agree. It was added in issue32502, but was never documented and used. Thank you Sebastian and Shantanu. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue39559] uuid.getnode() has unused argument

Serhiy Storchaka added the comment: New changeset 8b6f6526f857bb7523b0fcff09b45bc6471289e9 by Shantanu in branch 'master': bpo-39559: Remove unused, undocumented argument from uuid.getnode (GH-18369) https://github.com/python/cpython/commit/8b6f6526f857bb7523b0fcff09b45bc6471289e9 -

[issue39559] uuid.getnode() has unused argument

Sebastian Rittau added the comment: Code using this argument is in all likelihood already subtly broken, because it depends on non-existing functionality. I believe that a "hard" break would be better (for Python 3.9). -- ___ Python tracker

[issue39559] uuid.getnode() has unused argument

Shantanu added the comment: Github code search isn't great, but I was unable to find any usage of `uuid.getnode(getters=`, whereas I was able to find usage of `uuid.uuid1(node=` (even though `node` is optional and can be passed positionally). I'd be surprised if it was used in practice, give

[issue39559] uuid.getnode() has unused argument

Tal Einat added the comment: Simply removing the argument would be backwards-incompatible. Unless someone can show via a code search that this is never used in practice, we may want to consider deprecating this argument before removing it. -- nosy: +taleinat versions: +Python 3.9 -Py

[issue39559] uuid.getnode() has unused argument

Change by Shantanu : -- keywords: +patch pull_requests: +17743 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18369 ___ Python tracker ___ ___

[issue39559] uuid.getnode() has unused argument

Sebastian Rittau added the comment: Shantanu points out in https://github.com/python/typeshed/pull/3715 that the argument was made useless due to bpo-28009. -- ___ Python tracker ___

[issue39559] uuid.getnode() has unused argument

New submission from Sebastian Rittau : uuid.getnode() has an undocumented, keyword-only "getters" argument that gets discarded immediately. This is confusing when using code inspection tools and can give the wrong impression that you can somehow override the node getters when you can't. I rec