[issue39517] runpy calls open_code with Path object

Maor Kleinberger added the comment: Great, thank you! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue39517] runpy calls open_code with Path object

miss-islington added the comment: New changeset 0687bdf5def13ddca09e854113c0eac0772afea0 by Miss Islington (bot) in branch '3.8': bpo-39517: Allow runpy.run_path() to accept path-like objects (GH-18699) https://github.com/python/cpython/commit/0687bdf5def13ddca09e854113c0eac0772afea0 --

[issue39517] runpy calls open_code with Path object

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue39517] runpy calls open_code with Path object

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +18219 pull_request: https://github.com/python/cpython/pull/18862 ___ Python tracker _

[issue39517] runpy calls open_code with Path object

Steve Dower added the comment: Nope, just that I apparently forgot to merge (or forgot to come back after CI had finished). Thanks for the reminder! -- nosy: -miss-islington ___ Python tracker ___

[issue39517] runpy calls open_code with Path object

Steve Dower added the comment: New changeset 0911ea5c172264eaefa3efe4a1788159c160920d by Maor Kleinberger in branch 'master': bpo-39517: Allow runpy.run_path() to accept path-like objects (GH-18699) https://github.com/python/cpython/commit/0911ea5c172264eaefa3efe4a1788159c160920d --

[issue39517] runpy calls open_code with Path object

Maor Kleinberger added the comment: Hey there, the PR was approved a week ago, is there a reason it is not merged yet? -- ___ Python tracker ___ _

[issue39517] runpy calls open_code with Path object

Change by Maor Kleinberger : -- keywords: +patch pull_requests: +18060 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18699 ___ Python tracker ___

[issue39517] runpy calls open_code with Path object

Steve Dower added the comment: open_code is correct according to PEP 578, so the fix here is for runpy to ensure the path is absolute and pass it through os.fsdecode() before calling io.open_code(). -- nosy: +steve.dower versions: +Python 3.9 ___

[issue39517] runpy calls open_code with Path object

Maor Kleinberger added the comment: Not a direct solution, but I have offered that io.open_code should be changed to support pathlike objects: https://bugs.python.org/issue39691 -- nosy: +kmaork ___ Python tracker

[issue39517] runpy calls open_code with Path object

Tomas Ravinskas added the comment: Can't see anything about this in the docs, I just noticed that it breaks shiv after upgrade. -- ___ Python tracker ___

[issue39517] runpy calls open_code with Path object

Change by Karthikeyan Singaravelan : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue39517] runpy calls open_code with Path object

Karthikeyan Singaravelan added the comment: Is there documentation in runpy where it's stated that path objects are accepted for the function? If not this seems to be an enhancement. -- nosy: +ncoghlan, xtreak ___ Python tracker

[issue39517] runpy calls open_code with Path object

New submission from Tomas Ravinskas : runpy accepts Path like objects but open_code seems to only accept strings, so calling open_code with Path object throws TypeError. I think runpy should call str() on all path passed to open_code. The relevant line is 232 in runpy.py in function _get_code_f