[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Fixed in r66630. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I'm actually having a hard time trying to get memoryview to use PyObject_CheckReadBuffer. Eventually, test should be written in C, but for now are you ok with the compile test? ___ Python tracker <[EMAIL

[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The rest of the patch is fine with me (I assume you've run all the unit tests :-)). ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > I disagree. The test I added is really about compile, and its failure > was really just a side effect of the buffer bug. Well, I won't fight over it, but it's really meant to check an aspect of memoryview behaviour - otherwise why would it

[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: On Thu, Sep 25, 2008 at 6:39 AM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > > Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > > The test would be better in test_memoryview rather than in test_builtin. I disagree. The test I added

[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The test would be better in test_memoryview rather than in test_builtin. -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> _

[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Attaching patch and test. -- keywords: +needs review, patch nosy: +benjamin.peterson Added file: http://bugs.python.org/file11576/no_null_view.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: And the following statement crashes the interpreter: >>> compile(memoryview(b"text"), "name", "exec") -- nosy: +amaury.forgeotdarc priority: -> critical ___ Python tracker <[EMAIL PROTECTED

[issue3946] PyObject_CheckReadBuffer crashes on memoryview object

New submission from Roger Upole <[EMAIL PROTECTED]>: Sample code: PyObject *b=PyBytes_FromString("eh ?"); PyObject *mv=PyMemoryView_FromObject(b); PyObject_CheckReadBuffer(mv); >From following the chain of calls in PyObject_CheckReadBuffer, a few things are unclear.