[issue3945] compile error in _fileio.c (cygwin)

2008-09-23 Thread Hirokazu Yamamoto
Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment: Thanks, fixed in r66566(trunk). -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue3945] compile error in _fileio.c (cygwin)

2008-09-23 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: OK, please apply! -- keywords: -needs review resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3945] compile error in _fileio.c (cygwin)

2008-09-23 Thread Hirokazu Yamamoto
Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment: >The patch is OK, even if the second half is not necessary: >PyType_Ready() takes care of the ob_type field. Oh, OK. >Adding brackets in the macro would be wrong: the object layout is >different between 2.6 and 3.0. I Undarstand. How ab

[issue3945] compile error in _fileio.c (cygwin)

2008-09-23 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: The patch is OK, even if the second half is not necessary: PyType_Ready() takes care of the ob_type field. Adding brackets in the macro would be wrong: the object layout is different between 2.6 and 3.0. 3.0 does not have this problem b

[issue3945] compile error in _fileio.c (cygwin)

2008-09-23 Thread Hirokazu Yamamoto
New submission from Hirokazu Yamamoto <[EMAIL PROTECTED]>: Currently, fails to build trunk on cygwin. gcc -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. - I/home/WhiteRabbit/python-dev/trunk/./Include -I. -IInclude -I./Include -I/home/ WhiteRabbit/python-dev/trunk/Inc