[issue3939] Patch to implement a real ftplib test suite

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Thanks. That seems to have done the trick. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3939] Patch to implement a real ftplib test suite

Giampaolo Rodola' <[EMAIL PROTECTED]> added the comment: I think the patch in attachment could solve the problem. Note: done against the 2.x trunk; changes for 3.x are the same. Added file: http://bugs.python.org/file11640/test_ftplib.patch ___ Python tracke

[issue3939] Patch to implement a real ftplib test suite

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Giampaolo, I'm seeing some failures on the buildbots like this: http://python.org/dev/buildbot/stable/ia64%20Ubuntu%203.0/builds/612/step-test/0 Do you know where they are arising from? ___ Python track

[issue3939] Patch to implement a real ftplib test suite

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Commited in r66634. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3939] Patch to implement a real ftplib test suite

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Excellent! Barry gave me permission to put this in 2.6, so I'll do so soon. -- versions: +Python 2.6 -Python 2.7 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3939] Patch to implement a real ftplib test suite

Giampaolo Rodola' <[EMAIL PROTECTED]> added the comment: Patch modified after the remarks discussed with Benjamin is in attachment. Added file: http://bugs.python.org/file11582/test_ftplib.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3939] Patch to implement a real ftplib test suite

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Giampaolo, my review comments are on Rietveld: http://codereview.appspot.com/5698 ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3939] Patch to implement a real ftplib test suite

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Awesome! I'll look at this soon. -- assignee: -> benjamin.peterson priority: -> high ___ Python tracker <[EMAIL PROTECTED]> _

[issue3939] Patch to implement a real ftplib test suite

New submission from Giampaolo Rodola' <[EMAIL PROTECTED]>: ftplib module is currently lacking a test suite which actually connects to a FTP server and uses the FTP class methods and facilities. Bug #3911, discovered just a bunch of weeks before the stable release of Python 3.0, is an example of h