[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Change by Inada Naoki : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Inada Naoki added the comment: New changeset 5bbac8cbdf140ebce446ea4e7db2b20a5d7b8402 by Inada Naoki in branch 'master': bpo-39377: json: Update doc about the encoding option. (GH-18076) https://github.com/python/cpython/commit/5bbac8cbdf140ebce446ea4e7db2b20a5d7b8402 -- __

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Serhiy Storchaka added the comment: Please update the documentation which still mentions the encoding parameter. -- ___ Python tracker ___

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

STINNER Victor added the comment: I reopen the issue. > New changeset 5492bfcefec67b016e8239c0e9135bc2f03e3058 by Inada Naoki in > branch 'master': > bpo-39377: json: Remove the encoding option. (GH-18075) > https://github.com/python/cpython/commit/5492bfcefec67b016e8239c0e9135bc2f03e3058 Wo

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Karthikeyan Singaravelan added the comment: > Do you mean to say we should or shouldn't be raising an error? With > Inada-san's change you get this: Sorry, I misread the patch as only removal and didn't test the change completely. I am filing issues on code that I can find using this patter

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Inada Naoki added the comment: If this broke some real-world software and the pain is high enough, we can revert the change and add one more deprecation period, like all other removals. -- ___ Python tracker __

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Ammar Askar added the comment: Do you mean to say we should or shouldn't be raising an error? With Inada-san's change you get this: >>> json.loads("true", encoding='utf8') Traceback (most recent call last): File "", line 1, in File "C:\Users\ammar\workspace\cpython\lib\json\__init__.py",

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Karthikeyan Singaravelan added the comment: Should we be raising an error if encoding is present on 3.9 as part of kwargs? It's obtrusive but for people going from Python 3.7 to 3.9 there will be no change and they will keep assuming encoding parameter is valid. -- _

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Change by Inada Naoki : -- pull_requests: +17469 pull_request: https://github.com/python/cpython/pull/18076 ___ Python tracker ___ _

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Inada Naoki added the comment: New changeset 5492bfcefec67b016e8239c0e9135bc2f03e3058 by Inada Naoki in branch 'master': bpo-39377: json: Remove the encoding option. (GH-18075) https://github.com/python/cpython/commit/5492bfcefec67b016e8239c0e9135bc2f03e3058 --

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

Change by Inada Naoki : -- keywords: +patch pull_requests: +17468 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18075 ___ Python tracker ___

[issue39377] json.loads encoding parameter deprecation removal in Python 3.9

New submission from Karthikeyan Singaravelan : This is a followup of issue33461. The warning says about removal of the encoding parameter in 3.9 . It's already ignored since 3.1 hence I assume this should be raising a TypeError in 3.9 removing the deprecation warning. I am finding some projec