[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

STINNER Victor added the comment: Thanks Dong-hee Na for all these nice changes! -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Dong-hee Na added the comment: > Can we now close this issue? Or is there still something to do? There is no case on xxlib series except LMTP. I am going to open a new issue about LMTP. So let's close this :) -- ___ Python tracker

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

STINNER Victor added the comment: New changeset 62e3973395fb9fab2eb8f651bcd0fea4e695e1cf by Victor Stinner (Dong-hee Na) in branch 'master': bpo-39259: smtp.SMTP/SMTP_SSL now reject timeout = 0 (GH-17958) https://github.com/python/cpython/commit/62e3973395fb9fab2eb8f651bcd0fea4e695e1cf

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

STINNER Victor added the comment: Can we now close this issue? Or is there still something to do? -- ___ Python tracker ___ ___ Pyt

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

STINNER Victor added the comment: New changeset a190e2ade1a704a6b5a94464a0a19b140c7dd031 by Victor Stinner (Dong-hee Na) in branch 'master': bpo-39259: ftplib.FTP/FTP_TLS now reject timeout = 0 (GH-17959) https://github.com/python/cpython/commit/a190e2ade1a704a6b5a94464a0a19b140c7dd031

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Change by Dong-hee Na : -- pull_requests: +17367 pull_request: https://github.com/python/cpython/pull/17959 ___ Python tracker ___ _

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Change by Dong-hee Na : -- pull_requests: +17366 pull_request: https://github.com/python/cpython/pull/17958 ___ Python tracker ___ _

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

STINNER Victor added the comment: New changeset 1b335ae281631a12201fdec29b3c55d97166fc06 by Victor Stinner (Dong-hee Na) in branch 'master': bpo-39259: nntplib.NNTP/NNTP_SSL now reject timeout = 0 (GH-17936) https://github.com/python/cpython/commit/1b335ae281631a12201fdec29b3c55d97166fc06 -

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

STINNER Victor added the comment: New changeset 5d978a2e73e9ad934bcd260ae0a0db5cd0ca27d0 by Victor Stinner (Dong-hee Na) in branch 'master': bpo-39259: nntplib.NNTP/NNTP_SSL refactoring (GH-17939) https://github.com/python/cpython/commit/5d978a2e73e9ad934bcd260ae0a0db5cd0ca27d0 --

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Change by Dong-hee Na : -- pull_requests: +17351 pull_request: https://github.com/python/cpython/pull/17939 ___ Python tracker ___ _

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

STINNER Victor added the comment: New changeset c39b52f1527868c7ada9385669c38edf98858921 by Victor Stinner (Dong-hee Na) in branch 'master': bpo-39259: poplib now rejects timeout = 0 (GH-17912) https://github.com/python/cpython/commit/c39b52f1527868c7ada9385669c38edf98858921 -- ___

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Change by Dong-hee Na : -- pull_requests: +17344 pull_request: https://github.com/python/cpython/pull/17936 ___ Python tracker ___ _

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

STINNER Victor added the comment: ftplib: https://github.com/python/cpython/blob/efa3b51fd060352cc6220b27a1026e4d4d5401bd/Lib/ftplib.py#L155 nntplib: https://github.com/python/cpython/blob/2e6a8efa837410327b593dc83c57492253b1201e/Lib/nntplib.py#L1049 smtplib: https://github.com/python/cpytho

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Dong-hee Na added the comment: ftplib: https://github.com/python/cpython/blob/efa3b51fd060352cc6220b27a1026e4d4d5401bd/Lib/ftplib.py#L155 nntplib: https://github.com/python/cpython/blob/2e6a8efa837410327b593dc83c57492253b1201e/Lib/nntplib.py#L1049 smtplib: https://github.com/python/cpython/b

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Change by Dong-hee Na : -- keywords: +patch pull_requests: +17323 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17912 ___ Python tracker ___

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Dong-hee Na added the comment: Sure, I will submit the PR by tomorrow :) -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0

STINNER Victor added the comment: I agree, I was the one who suggest to reject timeout=0 when you added the parameter to imaplib :-) Do you want to work on a PR? -- ___ Python tracker _

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

Change by STINNER Victor : -- title: poplib.POP3/POP3_SSL should reject timeout = 0 -> poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode) ___ Python tracker __

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0

New submission from Dong-hee Na : Since poplib.POP3/POP3_SSL's implementation depends on socket.makefile, the client should reject if the timeout is zero. Because socket.makefile said that 'The socket must be in blocking mode' and if we set timeout to zero, the client does not operate as norma