[issue3911] ftplib.FTP.makeport() bug

2008-09-27 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Fixed in r66656. -- priority: -> release blocker resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> _

[issue3911] ftplib.FTP.makeport() bug

2008-09-22 Thread Giampaolo Rodola'
Giampaolo Rodola' <[EMAIL PROTECTED]> added the comment: > Would you like to contribute a patch? Done in issue #3939. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3911] ftplib.FTP.makeport() bug

2008-09-20 Thread Giampaolo Rodola'
Giampaolo Rodola' <[EMAIL PROTECTED]> added the comment: > Would you like to contribute a patch? Ok. I started working on a patch which implements a dummy asyncore-based FTP server including tests for all basic FTP() class methods. I'll contribute a patch as soon as I'll wrote IPv6 tests. _

[issue3911] ftplib.FTP.makeport() bug

2008-09-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: On Fri, Sep 19, 2008 at 6:23 PM, Giampaolo Rodola' <[EMAIL PROTECTED]> wrote: > > Giampaolo Rodola' <[EMAIL PROTECTED]> added the comment: > > At your discretion. I was thinking that it's not encouraging that such > an outstanding bug has p

[issue3911] ftplib.FTP.makeport() bug

2008-09-19 Thread Giampaolo Rodola'
Giampaolo Rodola' <[EMAIL PROTECTED]> added the comment: At your discretion. I was thinking that it's not encouraging that such an outstanding bug has passed silently until RC1. IMHO, a minimal test suite for the ftplib module would be really necessary. A dummy FTP server returning fixed respons

[issue3911] ftplib.FTP.makeport() bug

2008-09-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Why not just use floor divide (//)? -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3911] ftplib.FTP.makeport() bug

2008-09-19 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola' <[EMAIL PROTECTED]>: Python 3.0rc1 (r30rc1:66507, Sep 18 2008, 14:47:08) [MSC v.1500 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import ftplib >>> f = ftplib.FTP() >>> f.connect('mirrors.kernel.org') '22