[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Michael Felt added the comment: This issue was resolved by issue39802. Marking as fixed, and closed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Serhiy Storchaka added the comment: Thank you Michael. Sorry, I just missed that you are working on your PR. -- ___ Python tracker ___

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Michael Felt added the comment: Blinded - got the numbers wrong! So, again: Thanks for PR 18302. I followed your lead and made the additional changes and posted as PR 18303 in the hope this is easier for all. -- ___ Python tracker

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Michael Felt added the comment: Thanks again for PR 18202. I followed your lead and made the additional changes and posted as PR 18203. -- ___ Python tracker ___

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Change by Michael Felt : -- pull_requests: +17680 pull_request: https://github.com/python/cpython/pull/18303 ___ Python tracker ___

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Michael Felt added the comment: Here is the patch I am working on. I appreciate your example on how to deal with the undefined variables. I had done that incorrectly initially. -- Added file: https://bugs.python.org/file48876/bpo-39020-AIX.patch _

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Michael Felt added the comment: Have looked at your PR. It will not work on AIX because AIX libcurses is missing all four new functions. Once I finished my test on AIX - shall I add my patch as a file here, so you can integrate into yours? I hope that is easier than two PRs. -- __

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Michael Felt added the comment: removed 3.8, this is new for 3.9. Have established that all four functions added in issue38132 do not exist in stock AIX libcurses.a Was working on my own PR, but shall look at yours first. -- versions: -Python 3.8 __

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Serhiy Storchaka added the comment: NetBSD also uses non-ncurses implementation of curses, but it supports ESCDELAY, set_escdelay(), etc. This is not a difference between ncurses and non-ncurse, but a problem specific to the AIX implementation of curses. Please check that PR 18302 fixes the

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +17679 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18302 ___ Python tracker ___

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Michael Felt added the comment: Adding 3.8 before I post a PR - as I think the initial merge that introduced the regression was before master was considered 3.9. -- versions: +Python 3.8 ___ Python tracker

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Michael Felt added the comment: quote: Interesting, a comment in curses.h: * Notes: * a. ESCDELAY was an undocumented feature under AIX curses. * It gives the ESC expire time in milliseconds. iirc - that is a symbolic link to ncurses.h from ncurses-devel RPM package, not some

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Serhiy Storchaka added the comment: I prefer option (b). We can also just use #if !defined(_AIX) || defined(NCURSES_VERSION) Interesting, a comment in curses.h: * Notes: * a. ESCDELAY was an undocumented feature under AIX curses. * It gives the ESC expire time in milliseconds

[issue39020] [AIX] module _curses fails to build since ESCDELAY has been added

Change by Zachary Ware : -- components: +Build title: [AIX] module _ctypes fails to build since ESCDELAY has been added -> [AIX] module _curses fails to build since ESCDELAY has been added ___ Python tracker ___