[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Change by Chris Withers : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Chris Withers added the comment: New changeset aef7dc89879d099dc704bd8037b8a7686fb72838 by Chris Withers (Vegard Stikbakke) in branch 'master': bpo-38932: Mock fully resets child objects on reset_mock(). (GH-17409) https://github.com/python/cpython/commit/aef7dc89879d099dc704bd8037b8a7686fb72

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Vegard Stikbakke added the comment: Oh, right! Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Karthikeyan Singaravelan added the comment: Thanks Vegard for the report. The docs say "Child mocks and the return value mock (if any) are reset as well." so it makes sense to me to reset the return_value and side_effect of children. But as mentioned in the PR it's a behaviour change that so

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Change by Vegard Stikbakke : -- keywords: +patch pull_requests: +16889 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17409 ___ Python tracker ___

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Change by Vegard Stikbakke : -- versions: -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Vegard Stikbakke added the comment: I said MagicMock, but I meant Mock. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children

Change by Vegard Stikbakke : -- title: MagicMock.reset_mocks does not pass all arguments to its children -> unittest.mock.Mock.reset_mocks does not pass all arguments to its children ___ Python tracker _