[issue38617] Using Py_XINCREF to replace Py_INCREF in PyAST_CompileObject

hai shi added the comment: Got it, thanks, Serhiy. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue38617] Using Py_XINCREF to replace Py_INCREF in PyAST_CompileObject

Change by Serhiy Storchaka : -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38617] Using Py_XINCREF to replace Py_INCREF in PyAST_CompileObject

Serhiy Storchaka added the comment: The filename argument must be non-NULL. The code that uses c_filename requires this. Py_XDECREF in compiler_free() could be replaced with Py_DECREF. But this is too tiny change which does not have significant effect. Actually both Py_INCREF and Py_XDECREF

[issue38617] Using Py_XINCREF to replace Py_INCREF in PyAST_CompileObject

Change by hai shi : -- keywords: +patch pull_requests: +16491 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16963 ___ Python tracker ___

[issue38617] Using Py_XINCREF to replace Py_INCREF in PyAST_CompileObject

New submission from hai shi : 1) param is unpredictable; 2) the compiler_free() use Py_XDECREF(c->c_filename) in PyAST_CompileObject(); -- components: Interpreter Core messages: 355547 nosy: shihai1991 priority: normal severity: normal status: open title: Using Py_XINCREF to replace Py_