[issue38519] Internal include files missing on Windows

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue38519] Internal include files missing on Windows

miss-islington added the comment: New changeset 07eee640cb3a4eaf1df942bc31a891e7517de763 by Miss Skeleton (bot) in branch '3.8': bpo-38519: Internal include files missing on Windows (GH-16921) https://github.com/python/cpython/commit/07eee640cb3a4eaf1df942bc31a891e7517de763 -- nosy:

[issue38519] Internal include files missing on Windows

Steve Dower added the comment: New changeset edb172a87296d9359593a23cd9a09f5867ea1f0e by Steve Dower (Zackery Spytz) in branch 'master': bpo-38519: Internal include files missing on Windows (GH-16921) https://github.com/python/cpython/commit/edb172a87296d9359593a23cd9a09f5867ea1f0e

[issue38519] Internal include files missing on Windows

Change by miss-islington : -- pull_requests: +16493 pull_request: https://github.com/python/cpython/pull/16966 ___ Python tracker ___ __

[issue38519] Internal include files missing on Windows

Zackery Spytz added the comment: Hi, Steve. I've created a PR for this. -- nosy: +ZackerySpytz ___ Python tracker ___ ___ Python-bu

[issue38519] Internal include files missing on Windows

Change by Zackery Spytz : -- keywords: +patch pull_requests: +16453 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16921 ___ Python tracker ___

[issue38519] Internal include files missing on Windows

Steve Dower added the comment: If someone wants to fix this before I do, the change goes in PC/layout/main.py to remove the filter for directories named "internal" - we shouldn't need a filter there at all now that we include everything in the distro. --

[issue38519] Internal include files missing on Windows

New submission from Steve Dower : The include/internal directory is not being included in the packages published to nuget.org or the Microsoft Store. This prevents some advanced users from being able to compile against these packages. -- assignee: steve.dower components: Windows mess