[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Benjamin Peterson added the comment: All fixed now, right? -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

miss-islington added the comment: New changeset 193366e25c4f84a58d2f6c6c577fd9f0143dc6e1 by Miss Islington (bot) (Pablo Galindo) in branch '3.7': [3.7] bpo-38395: Fix ownership in weakref.proxy methods (GH-16632) (GH-16663) https://github.com/python/cpython/commit/193366e25c4f84a58d2f6c6c577f

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Change by Pablo Galindo Salgado : -- priority: release blocker -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Pablo Galindo Salgado added the comment: New changeset 526ef856dd598fd3cefdfadeb18ede7a8e57aa41 by Pablo Galindo in branch '3.8': [3.8] bpo-38395: Fix ownership in weakref.proxy methods (GH-16632) (GH-16662) https://github.com/python/cpython/commit/526ef856dd598fd3cefdfadeb18ede7a8e57aa41 -

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Change by Pablo Galindo Salgado : -- pull_requests: +16245 pull_request: https://github.com/python/cpython/pull/16662 ___ Python tracker ___ ___

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Change by Pablo Galindo Salgado : -- pull_requests: +16246 pull_request: https://github.com/python/cpython/pull/16663 ___ Python tracker ___ ___

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Change by Pablo Galindo Salgado : -- pull_requests: +16244 pull_request: https://github.com/python/cpython/pull/16661 ___ Python tracker ___ ___

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Pablo Galindo Salgado added the comment: New changeset 10cd00a9e3c22af37c748ea5a417f6fb66601e21 by Pablo Galindo in branch 'master': bpo-38395: Fix ownership in weakref.proxy methods (GH-16632) https://github.com/python/cpython/commit/10cd00a9e3c22af37c748ea5a417f6fb66601e21 -- ___

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Benjamin Peterson added the comment: Note I'm going to ignore this for the purposes of 2.7.17 because it doesn't look like a new regression. -- ___ Python tracker ___ ___

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Pablo Galindo Salgado added the comment: I'm marking this as release blocker for the 3.8 incoming release so we don't forget about fixing this. -- nosy: +pablogsal ___ Python tracker ___

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Change by Pablo Galindo Salgado : -- nosy: +benjamin.peterson, lukasz.langa, ned.deily priority: normal -> release blocker ___ Python tracker ___ __

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Change by Pablo Galindo Salgado : -- versions: +Python 2.7, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Change by Pablo Galindo Salgado : -- versions: +Python 3.7, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +16218 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16632 ___ Python tracker __

[issue38395] proxy_contains (weakref.proxy) can access an object with 0 refcount

New submission from Sam Gross : The implementation of weakref.proxy's methods call back into the Python API using a "borrowed reference" of the weakly referenced object (acquired via PyWeakref_GET_OBJECT). This API call may delete the last reference to the object (either directly or via GC),