[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Kyle Stanley added the comment: > I hope it is fixed now. > Thanks, Kyle! No problem, thanks for looking over it. Let me know if the warning comes up again. If it does, I'll be sure to look into it. -- ___ Python tracker

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Change by Andrew Svetlov : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Andrew Svetlov added the comment: I hope it is fixed now. Thanks, Kyle! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

miss-islington added the comment: New changeset 33dd75a28fe2ec6e85c5d3b315b5a9d4cf0652db by Miss Islington (bot) in branch '3.8': bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552) https://github.com/python/cpython/commit/33dd75a28fe2ec6e85c5d3b315b5a9d4cf0652db

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Change by miss-islington : -- pull_requests: +17372 pull_request: https://github.com/python/cpython/pull/17963 ___ Python tracker ___ __

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

miss-islington added the comment: New changeset 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 by Miss Islington (bot) (Kyle Stanley) in branch 'master': bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552) https://github.com/python/cpython/commit/0ca7cc7fc0518c24dc9b78c38418e

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Change by Kyle Stanley : -- keywords: +patch pull_requests: +16140 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16552 ___ Python tracker ___ ___

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Kyle Stanley added the comment: > Another consideration is if we want this method to join the threads to be > called in `ThreadedChildWatcher.close()`. An additional benefit of having the method called from `close()` is that it means we don't have to modify the tests directly. Also, Threaded

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Kyle Stanley added the comment: First I'll work on adding a new method. Here's a few potential names, ordered roughly by my preferences: 1) join_threads() 2) shutdown_threads() 3) shutdown_threadpool() The first and second options are roughly equal, but I think join_threads() is a bit mor

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Kyle Stanley added the comment: I can try to work on fixing this. -- nosy: +aeros167 ___ Python tracker ___ ___ Python-bugs-list ma

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

Change by STINNER Victor : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

New submission from STINNER Victor : Warning seen o AMD64 Ubuntu Shared 3.x buildbot: https://buildbot.python.org/all/#/builders/141/builds/2593 test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ... Warning -- threading_cleanup() failed to cleanup 1 thread