[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-10-01 Thread STINNER Victor
STINNER Victor added the comment: Nick merged my two PRS, so the initial concern is gone :-) I close the issue. Thanks for the feedback, it was an interesting talk. Sorry for the bad timing. I dislike working under pressure of a deadline :-( -- resolution: -> fixed stage: patch revi

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-10-01 Thread Łukasz Langa
Łukasz Langa added the comment: I suggest closing this and following up in BPO-38304 about a possible graceful error message during invalid embedding. -- priority: release blocker -> normal ___ Python tracker __

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: > Binary compatibility of an embedding-only struct is totally unnecessary, as > posted on the thread. Well, I'm fine with removing PyConfig.struct_size right now. I wrote two PRs to remove it: * PR 16500 (code) * https://github.com/python/peps/pull/1185 (PE

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Nick Coghlan
Change by Nick Coghlan : -- keywords: +patch pull_requests: +16084 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/16496 ___ Python tracker __

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Łukasz Langa
Change by Łukasz Langa : -- versions: +Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Steve Dower
Steve Dower added the comment: (Continuing from the email thread, so read that for context if you haven't) Binary compatibility of an embedding-only struct is totally unnecessary, as posted on the thread. There's no feasible way to embed cross-Python versions on any platform, so we should ju

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Nick Coghlan
Nick Coghlan added the comment: (I'm currently working a PR for this that Victor can review) -- assignee: -> ncoghlan ___ Python tracker ___ _

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Nick Coghlan
New submission from Nick Coghlan : (Nosy list is RM, PEP 587 BDFL-Delegate, PEP 587 author) Filing as a release blocker, given that I don't think we should ship rc1 until consensus has been reached on the last minute changes to the PEP 587 configuration API. Thread at https://mail.python.or