[issue38083] Minor improvements in asdl_c.py and Python-ast.c

Serhiy Storchaka added the comment: Agree. The third item is actually a bug fix, but it is unlikely that such bug can be exposed in real code. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38083] Minor improvements in asdl_c.py and Python-ast.c

Thomas Wouters added the comment: This doesn't feel like a change that's worth backporting to 3.8 at this point. Do you agree? Is there anything left to do for this bug? -- ___ Python tracker __

[issue38083] Minor improvements in asdl_c.py and Python-ast.c

Thomas Wouters added the comment: New changeset 43c9731334470573209464b7f67914d386457efc by T. Wouters (Serhiy Storchaka) in branch 'master': bpo-38083: Minor improvements in asdl_c.py and Python-ast.c. (GH-15824) https://github.com/python/cpython/commit/43c9731334470573209464b7f67914d386457e

[issue38083] Minor improvements in asdl_c.py and Python-ast.c

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +15473 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15824 ___ Python tracker ___

[issue38083] Minor improvements in asdl_c.py and Python-ast.c

New submission from Serhiy Storchaka : * Use the const qualifier for constant C strings. This will save memory for their copy in a modifiable memory. * Intern field and attribute names. This will save time, as comparing interned strings is faster. * Temporary incref a borrowed reference to a l