[issue38075] Make random module PEP-384 compatible

STINNER Victor added the comment: New changeset 00d7cd8ab8db2c1e1f591ade828f88a1a973d70f by Victor Stinner in branch 'master': bpo-38075: Fix random_seed(): use PyObject_CallOneArg() (GH-18897) https://github.com/python/cpython/commit/00d7cd8ab8db2c1e1f591ade828f88a1a973d70f -- ___

[issue38075] Make random module PEP-384 compatible

STINNER Victor added the comment: Commit 04f0bbfbedf8d2bb69b012f853de6648b1a9f27f introduced a regression: bpo-39918. I proposed PR 18897 to fix it. -- ___ Python tracker __

[issue38075] Make random module PEP-384 compatible

Change by STINNER Victor : -- pull_requests: +18255 pull_request: https://github.com/python/cpython/pull/18897 ___ Python tracker ___ __

[issue38075] Make random module PEP-384 compatible

STINNER Victor added the comment: commit 09dc2c672f937cbe53300cb680fca1f9c78ff976 Author: Dino Viehland Date: Sun Sep 15 15:51:44 2019 +0100 Fix missing dec ref (#16158) diff --git a/Modules/_randommodule.c b/Modules/_randommodule.c index 8b0a0244bf..1ea2bf28ab 100644 --- a/Modules/_ra

[issue38075] Make random module PEP-384 compatible

STINNER Victor added the comment: > bpo-38075: Port _randommodule.c to PEP-384 (GH-15798) It seems like this change introduced a reference leak: bpo-38176. -- nosy: +vstinner ___ Python tracker

[issue38075] Make random module PEP-384 compatible

Thomas Wouters added the comment: New changeset 04f0bbfbedf8d2bb69b012f853de6648b1a9f27f by T. Wouters (Dino Viehland) in branch 'master': bpo-38075: Port _randommodule.c to PEP-384 (GH-15798) https://github.com/python/cpython/commit/04f0bbfbedf8d2bb69b012f853de6648b1a9f27f -- nosy:

[issue38075] Make random module PEP-384 compatible

Dino Viehland added the comment: There's several different reasons why these changes are beneficial. It'll help make the modules more compatible with PEP 554 in the future, enable more code re-use across Python VMs, reduce code maintenance going forward, and may also help with performance o

[issue38075] Make random module PEP-384 compatible

Change by Christian Heimes : -- nosy: +christian.heimes resolution: fixed -> stage: resolved -> patch review status: closed -> open ___ Python tracker ___

[issue38075] Make random module PEP-384 compatible

Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker ___ __

[issue38075] Make random module PEP-384 compatible

Serhiy Storchaka added the comment: I have the same questions. The new code looks more complex and cumbersome. What is the benefit of all these changes? I see you have created many similar issues. Would be nice to discuss first on the Python-Dev list what they do and why they are needed. --

[issue38075] Make random module PEP-384 compatible

Raymond Hettinger added the comment: I'm curious what this does for us. _randommodule.c isn't public. Internally, we get to use our full ABI, not just the stable public ABI. I'm unclear on why this needs to change at all. Is code like this deemed broken in some way? -- nosy: +rhe

[issue38075] Make random module PEP-384 compatible

Change by Dino Viehland : -- keywords: +patch pull_requests: +15450 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15798 ___ Python tracker ___ __

[issue38075] Make random module PEP-384 compatible

New submission from Dino Viehland : Make random module PEP-384 compatible -- assignee: dino.viehland components: Extension Modules messages: 351509 nosy: dino.viehland, eric.snow priority: normal severity: normal status: open title: Make random module PEP-384 compatible versions: Python