[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Ned Deily added the comment: (Removing “3.7regression” as the problematic change for 3.7 had not yet been released.) -- keywords: -3.7regression ___ Python tracker ___ __

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Pablo Galindo Salgado added the comment: New changeset 1b1796df3a4292067a174faa11b1a852f79e98e3 by Pablo Galindo in branch '3.7': [3.7] bpo-37915: Fix comparison between tzinfo objects and timezone objects (GH-15390) (GH-15417) https://github.com/python/cpython/commit/1b1796df3a4292067a174fa

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Change by Pablo Galindo Salgado : -- keywords: +3.7regression -patch nosy: +ned.deily resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7, Python 3.9 ___ Python tracker

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Change by Pablo Galindo Salgado : -- pull_requests: +15118 pull_request: https://github.com/python/cpython/pull/15417 ___ Python tracker ___ ___

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

miss-islington added the comment: New changeset 5c77730300c0358d7bebd2bb39ea5d10222a3d9a by Miss Islington (bot) in branch '3.8': bpo-37915: Fix comparison between tzinfo objects and timezone objects (GH-15390) https://github.com/python/cpython/commit/5c77730300c0358d7bebd2bb39ea5d10222a3d9a

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Change by miss-islington : -- pull_requests: +15107 pull_request: https://github.com/python/cpython/pull/15399 ___ Python tracker ___ __

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

miss-islington added the comment: New changeset 4be11c009abe88175fa164b45e4838e7267dfa97 by Miss Islington (bot) (Pablo Galindo) in branch 'master': bpo-37915: Fix comparison between tzinfo objects and timezone objects (GH-15390) https://github.com/python/cpython/commit/4be11c009abe88175fa164

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Change by Pablo Galindo Salgado : -- nosy: +lukasz.langa priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Pablo Galindo Salgado added the comment: Thanks, Tom and Karthikeyan for the finding and the debugging :) -- ___ Python tracker ___ ___

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Pablo Galindo Salgado added the comment: This is due to an incorrect type check in the timezone_richcompare, it should be a comparison against PyDateTime_TimeZoneType not against PyDateTime_TZInfoType. The segfault is due to an invalid casting to PyDateTime_TimeZoneType (the child) from the

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Tom Augspurger added the comment: Thanks for debugging this Karthikeyan and for the quick fix Pablo! -- ___ Python tracker ___ ___

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +15100 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15390 ___ Python tracker __

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Karthikeyan Singaravelan added the comment: Seems this is due to issue37685 (dde944f9df) on bisecting datetime related changes. Adding Serhiy. I guess this could be marked as release blocker. Here is a simplified reproducer on extracting pytz.utc source [0] which is an object of simple subcla

[issue37915] Segfault in comparison between datetime.timezone.utc and pytz.utc

Change by Karthikeyan Singaravelan : -- title: Segfault in comparison between datetime.timezone.utc and putz.utc -> Segfault in comparison between datetime.timezone.utc and pytz.utc ___ Python tracker __