[issue37902] Add scrolling for IDLE browsers

Terry J. Reedy added the comment: Thanks for the patch. More IDLE patches would be welcome should you want to attack something else. Possible browser scrolling refinements: 1. Scroll by an integral number of labels. This is easy with text. For our synthesized tree, we would have to calcu

[issue37902] Add scrolling for IDLE browsers

miss-islington added the comment: New changeset 16af39aa84cc3553c51d57461964ab4e28029184 by Miss Islington (bot) in branch '3.7': bpo-37902: IDLE: Add scrolling for IDLE browsers. (GH-15368) https://github.com/python/cpython/commit/16af39aa84cc3553c51d57461964ab4e28029184 -- __

[issue37902] Add scrolling for IDLE browsers

miss-islington added the comment: New changeset 9c2654d1aa85968fede1b888fba86aebc06c5be6 by Miss Islington (bot) in branch '3.8': bpo-37902: IDLE: Add scrolling for IDLE browsers. (GH-15368) https://github.com/python/cpython/commit/9c2654d1aa85968fede1b888fba86aebc06c5be6 -- nosy: +

[issue37902] Add scrolling for IDLE browsers

Change by miss-islington : -- pull_requests: +15348 pull_request: https://github.com/python/cpython/pull/15690 ___ Python tracker ___ __

[issue37902] Add scrolling for IDLE browsers

Change by miss-islington : -- pull_requests: +15347 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/15689 ___ Python tracker ___ ___

[issue37902] Add scrolling for IDLE browsers

Terry J. Reedy added the comment: New changeset 2cd902585815582eb059e3b40e014ebe4e7fdee7 by Terry Jan Reedy (GeeTransit) in branch 'master': bpo-37902: IDLE: Add scrolling for IDLE browsers. (#15368) https://github.com/python/cpython/commit/2cd902585815582eb059e3b40e014ebe4e7fdee7 -

[issue37902] Add scrolling for IDLE browsers

Terry J. Reedy added the comment: Don't worry more about tests until I look at what you have done already. -- ___ Python tracker ___ __

[issue37902] Add scrolling for IDLE browsers

Terry J. Reedy added the comment: 'mousescroll' was not exact because the mouse is also used to scroll with the scrollbar. 'handlescroll' is worse. 'wheelscroll' seems awkward. 'scrollwheel' (scroll with the mouse wheel) is specific. At least in idlelib, event handlers are routinely calle

[issue37902] Add scrolling for IDLE browsers

George Zhang added the comment: Also, how should I get the new code coverage percentage (or should it be ignored for now)? I'm thinking of adding a few more tests that send invalid events which would raise KeyError but I don't think that this behaviour will be used (and it's not documente

[issue37902] Add scrolling for IDLE browsers

George Zhang added the comment: I renamed mousescroll to handlescroll as it's an independent callback function and I think it fits its use case better. I can keep it as mousescroll if you like though. The handlescroll function is now a standalone module function in tree.py and the EditorWi

[issue37902] Add scrolling for IDLE browsers

Terry J. Reedy added the comment: I won't merge with mousescroll duplicated, or worse, triplicated. If 'self.text/canvas' is replaced with 'event.widget', then the 'self' parameter can be deleted and the function made a standalone module function. For now, put it in tree, copied with the d

[issue37902] Add scrolling for IDLE browsers

George Zhang added the comment: Looks like my PRs are getting out of hand... This is the final PR :P -- ___ Python tracker ___ ___

[issue37902] Add scrolling for IDLE browsers

Change by George Zhang : -- pull_requests: +15079 pull_request: https://github.com/python/cpython/pull/15368 ___ Python tracker ___

[issue37902] Add scrolling for IDLE browsers

Change by George Zhang : -- pull_requests: -15077 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue37902] Add scrolling for IDLE browsers

Change by George Zhang : -- pull_requests: -15076 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue37902] Add scrolling for IDLE browsers

Change by George Zhang : -- pull_requests: +15076 pull_request: https://github.com/python/cpython/pull/15360 ___ Python tracker ___

[issue37902] Add scrolling for IDLE browsers

Change by George Zhang : -- pull_requests: +15076, 15077 pull_request: https://github.com/python/cpython/pull/15360 ___ Python tracker ___ _

[issue37902] Add scrolling for IDLE browsers

Change by George Zhang : -- pull_requests: -15072 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue37902] Add scrolling for IDLE browsers

George Zhang added the comment: I looked at the code for scrolling and moved it over to the ScrolledCanvas and TreeNode (because it uses a Label that sits on the canvas, meaning we have to rebind it here). I haven't figured out how to add the scroll-by-pressing-down-and-moving way but I'll

[issue37902] Add scrolling for IDLE browsers

Change by George Zhang : -- keywords: +patch pull_requests: +15072 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15360 ___ Python tracker

[issue37902] Add scrolling for IDLE browsers

Terry J. Reedy added the comment: #31461 is the index issue for class browser. Mousewheel scrolling was listed without an issue. Now there is, and this has been added as a dependency. -- ___ Python tracker __

[issue37902] Add scrolling for IDLE browsers

Terry J. Reedy added the comment: I agree. We added mousewheel scrolling to editor just over a year ago and later added it to text views. But for the browsers, I want to factor out the common code. It is a bit tricky since the 3 major systems each send different events for the same action

[issue37902] Add scrolling for IDLE browsers

New submission from George Zhang : I've just started using IDLE's module/path browsers and they offer a lot! Putting aside the issue of them opening in separate windows, they have a small change that could be made to improve them. Both browsers have scrollbars, but (for me at least) I cannot