[issue37661] venv activation scripts erroneously check if __VENV_PROMPT__ is defined

Brett Cannon added the comment: Fixed by issue37663. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue37661] venv activation scripts erroneously check if __VENV_PROMPT__ is defined

mental added the comment: I've added a PR (#1492) since it was a simple fix. Please feel free to reject if this issue is reserved or some other fatal issue with the solution is found. Otherwise I'd love a review and a double check (mainly paranoia from not wanting to mess up). --

[issue37661] venv activation scripts erroneously check if __VENV_PROMPT__ is defined

Change by mental : -- keywords: +patch pull_requests: +14703 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14932 ___ Python tracker ___ _

[issue37661] venv activation scripts erroneously check if __VENV_PROMPT__ is defined

mental added the comment: Brett, Vinay: mind if I handle this one? I'm looking for a good first issue to tackle. In terms of solutions I propose adding short circuiting logic to the checks for custom prompts to test against the default case `({context.env_name})` -- nosy: +mental _

[issue37661] venv activation scripts erroneously check if __VENV_PROMPT__ is defined

New submission from Brett Cannon : If you look at https://github.com/python/cpython/blob/master/Lib/venv/__init__.py#L112-L113 you will see that the prompt context for a virtual environment is always set. Then if you look at the string substitutions for the activation scripts you will also s