[issue37651] Change of inheritance of asyncio.CancelledError needs documentation

2019-09-11 Thread miss-islington
miss-islington added the comment: New changeset e784bb7c6b2a52e80d7c03cb85e5faab11a1ccbd by Miss Islington (bot) in branch '3.8': bpo-37651: Document CancelledError is now a subclass of BaseException (GH-15950) https://github.com/python/cpython/commit/e784bb7c6b2a52e80d7c03cb85e5faab11a1ccbd

[issue37651] Change of inheritance of asyncio.CancelledError needs documentation

2019-09-11 Thread Andrew Svetlov
Andrew Svetlov added the comment: Done, thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37651] Change of inheritance of asyncio.CancelledError needs documentation

2019-09-11 Thread miss-islington
Change by miss-islington : -- pull_requests: +15594 pull_request: https://github.com/python/cpython/pull/15959 ___ Python tracker ___ __

[issue37651] Change of inheritance of asyncio.CancelledError needs documentation

2019-09-11 Thread miss-islington
miss-islington added the comment: New changeset 7b69069e9aa0047a0dbe8af1a67aa2b355dc68d8 by Miss Islington (bot) (Xtreak) in branch 'master': bpo-37651: Document CancelledError is now a subclass of BaseException (GH-15950) https://github.com/python/cpython/commit/7b69069e9aa0047a0dbe8af1a67aa

[issue37651] Change of inheritance of asyncio.CancelledError needs documentation

2019-09-11 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. I think this documentation part is missed in the linked PR. I will prepare a PR that adds the versionchanged directive. Perhaps we can also remove the important section or perhaps just keep the try..except example to ensure u

[issue37651] Change of inheritance of asyncio.CancelledError needs documentation

2019-09-11 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +15585 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15950 ___ Python tracker ___

[issue37651] Change of inheritance of asyncio.CancelledError needs documentation

2019-07-22 Thread Gary van der Merwe
New submission from Gary van der Merwe : asyncio.CancelledError inheritance was changed in 3.8. https://bugs.python.org/issue32528 https://github.com/python/cpython/commit/431b540bf79f0982559b1b0e420b1b085f667bb7 The documentation still instructs the user to perform a pattern needed before t