[issue37538] Refactor zipfile to ease subclassing and enhancement

Change by Daniel Hillier : -- keywords: +patch pull_requests: +14725 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14957 ___ Python tracker ___ _

[issue37538] Refactor zipfile to ease subclassing and enhancement

Daniel Hillier added the comment: Hi, Here is a pull request against my fork: https://github.com/danifus/cpython/pull/1/files The overall behaviour of zipfile remains the same and I've tried to call out any behaviour changes in the extended commit messages (usually with ** markers). There

[issue37538] Refactor zipfile to ease subclassing and enhancement

Serhiy Storchaka added the comment: I did not read your code yet, but I think it is the right way. If your btanch contains changes which you do not want to commit to CPython, but which makes the purpose of other changes clearer, you can create a PR against the master in your fork --

[issue37538] Refactor zipfile to ease subclassing and enhancement

Daniel Hillier added the comment: I've started a branch on my github fork if anyone wants to follow along. https://github.com/danifus/cpython/tree/zipfile_refactor Is there a better way to manage this in terms of review and suggestions as I add more commits? --

[issue37538] Refactor zipfile to ease subclassing and enhancement

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue37538] Refactor zipfile to ease subclassing and enhancement

New submission from Daniel Hillier : I've written https://github.com/danifus/pyzipper which incorporates a refactor of zipfile.py in order to support winzip AES encryption. I don't intend to include the crypto code but I would like to incorporate the refactor to help others subclass and extend t