[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: My question was more for Zachary who proposed: "backporting GH-9901 to 2.7 would probably also be good even though it was solving a different issue". But as I wrote, I'm not comfortable to backport such change in Python 2.7. I prefer to avoid changes except

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread Steve Dower
Steve Dower added the comment: > I suggest to close the issue and see if the bug comes back. You opened it, so sure :) -- stage: -> resolved status: open -> closed ___ Python tracker __

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: Me: > Should PCbuild/pyproject.vcxproj explicitly import python.props which defines > it? Steve: > It already does :) Well, I was confused by the message. I just fixed the message. I suggest to close the issue and see if the bug comes back. -- _

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: Aaaah, CIs are funny. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread Steve Dower
Steve Dower added the comment: > Should PCbuild/pyproject.vcxproj explicitly import python.props which defines > it? It already does :) This is more likely because the previous build on that buildbot crashed(?) or because it was aborted during test_multiprocessing: https://buildbot.python.

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset 49032fa7e1cc1b6dc12b898daac24b75bae7572c by Victor Stinner in branch '2.7': bpo-37396, PCbuild: Include "_d" in "Killing any running ..." message (GH-14370) https://github.com/python/cpython/commit/49032fa7e1cc1b6dc12b898daac24b75bae7572c

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: > How can you tell that $(PyDebugExt) is not set? Note that the "Killing any > running python.exe instances..." line is hard-coded, it does not currently > include $(PyDebugExt) (though it probably should). Adding that to the > message would be a good firs

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +14187 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14370 ___ Python tracker ___ _

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-24 Thread Zachary Ware
Zachary Ware added the comment: How can you tell that $(PyDebugExt) is not set? Note that the "Killing any running python.exe instances..." line is hard-coded, it does not currently include $(PyDebugExt) (though it probably should). Adding that to the message would be a good first step; ba

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-24 Thread STINNER Victor
New submission from STINNER Victor : x86 Windows XP 2.7: https://buildbot.python.org/all/#/builders/45/builds/429 Killing any running python.exe instances... ... C:\Program Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppClean.targets(74,5): warning : Access to the path 'd:\cygwin\home\db3l\bui