[issue37315] Deprecate using math.factorial() with floats

2019-06-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37315] Deprecate using math.factorial() with floats

2019-06-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 231aad38493c871dd32930a21d256cbacd2ae20c by Serhiy Storchaka in branch 'master': bpo-37315: Deprecate accepting floats in math.factorial(). (GH-14147) https://github.com/python/cpython/commit/231aad38493c871dd32930a21d256cbacd2ae20c

[issue37315] Deprecate using math.factorial() with floats

2019-06-17 Thread Mark Dickinson
Mark Dickinson added the comment: +1 from me; let's make `factorial` consistent with the other integer-based math module functions. -- ___ Python tracker ___ ___

[issue37315] Deprecate using math.factorial() with floats

2019-06-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +13988 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14147 ___ Python tracker ___

[issue37315] Deprecate using math.factorial() with floats

2019-06-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently math.factorial() accepts integer-like objects (including objects with defined __index__) as well as float instances with integral value (but not arbitrary float-like objects with defined __float__). I suppose this was happen because factorial()