[issue3725] telnetlib module broken by str to unicode conversion

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Fixed in r66904. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3725] telnetlib module broken by str to unicode conversion

Dmitry Vasiliev <[EMAIL PROTECTED]> added the comment: The patch is good. It's exactly what I told about in msg72132. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3725] telnetlib module broken by str to unicode conversion

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Yes, the patch is good. I think that documentation (both Doc\library\telnetlib.rst and the docstrings in telnetlib.py) should reflect the change, at least the code samples. -- nosy: +amaury.forgeotdarc __

[issue3725] telnetlib module broken by str to unicode conversion

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The patch looks pretty straightforward to me. If somebody else gives their nod, I'll apply it. -- assignee: -> benjamin.peterson nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]>

[issue3725] telnetlib module broken by str to unicode conversion

STINNER Victor <[EMAIL PROTECTED]> added the comment: I think that telnet should only use bytes (and not characters). For an HTTP connection, the charset is only known after parsing the HTTP headers. So telnet should use bytes, and your HTTP browser will convert bytes to characters using the c

[issue3725] telnetlib module broken by str to unicode conversion

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3725] telnetlib module broken by str to unicode conversion

Dmitry Vasiliev <[EMAIL PROTECTED]> added the comment: I think only bytes need to be allowed for write() and read*() because of low-level nature of Telnet. I can create a patch later. ___ Python tracker <[EMAIL PROTECTED]> __

[issue3725] telnetlib module broken by str to unicode conversion

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- priority: -> critical ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bug

[issue3725] telnetlib module broken by str to unicode conversion

New submission from Dmitry Vasiliev <[EMAIL PROTECTED]>: Simple example: >>> from telnetlib import Telnet >>> t = Telnet("google.com", 80) >>> t.write("GET / HTTP/1.1\r\n") Traceback (most recent call last): File "", line 1, in File "/py3k/Lib/telnetlib.py", line 280, in write s