[issue37206] Incorrect application of Argument Clinic to dict.pop()

Serhiy Storchaka added the comment: New changeset d322abbb83eb751045246a70f39d040d13a6108b by Serhiy Storchaka in branch '3.8': [3.8] bpo-37206: Unrepresentable default values no longer represented as None. (GH-13933) (GH-16141) https://github.com/python/cpython/commit/d322abbb83eb751045246a

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Change by Serhiy Storchaka : -- pull_requests: +15751 pull_request: https://github.com/python/cpython/pull/16141 ___ Python tracker ___

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Serhiy Storchaka added the comment: New changeset 279f44678c8b84a183f9eeb85e0b086228154497 by Serhiy Storchaka in branch 'master': bpo-37206: Unrepresentable default values no longer represented as None. (GH-13933) https://github.com/python/cpython/commit/279f44678c8b84a183f9eeb85e0b08622815

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Ned Deily added the comment: I think you mean 3.8b2 so that would be Łukasz's call. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Inada Naoki added the comment: I agree that this is a bug in many API docstrings, and PR 13933 is the right approach to fix all bugs in the future. But in case of dict.pop(), this is not only a bug, but a regression. May I merge PR-13935 to fix the regression in 3.7b2? -- __

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Ned Deily added the comment: As I noted on the PR: "I'm not going to get into whether this PR is appropriate for 3.8 but, assuming it were, I would be very concerned about making a change of this size and complexity in 3.7 at this stage in its lifecycle." -- nosy: +lukasz.langa, ned.

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Serhiy Storchaka added the comment: PR 13933 implements the first option. It fixes similar issues with other functions so it should be backported to 3.7. The second option is considered as a new feature and can go only in 3.9. -- ___ Python tracke

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Change by Inada Naoki : -- pull_requests: +13803 pull_request: https://github.com/python/cpython/pull/13935 ___ Python tracker ___ _

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Raymond Hettinger added the comment: I would think that the best course of action is to revert the dict.pop() check-in for Python3.8, then reapply in 3.9 once a plan is worked out to expand the capabilities of the argument clinic and the expressiveness of signatures. The latter seem more li

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +13800 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13933 ___ Python tracker ___

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Serhiy Storchaka added the comment: I am working on this issue and almost done. The questions is what inspect.Signature() and inspect.getfullargspec() should do with such functions. 1. Raise an exception as they did in old Python versions and as they do with builtin functions not converted

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Raymond Hettinger added the comment: > It is just a signature wrong. Yes, that is the part that needs to be fixed. The information it provides is incorrect. That is why this function wasn't converted long ago. -- ___ Python tracker

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Serhiy Storchaka added the comment: The code generated by Argument Clinic is correct. >>> {}.pop(1) Traceback (most recent call last): File "", line 1, in KeyError: 1 >>> {}.pop(1, None) It is just a signature wrong. Some earlier versions of Argument Clinic allowed you to write "default=u

[issue37206] Incorrect application of Argument Clinic to dict.pop()

Change by Karthikeyan Singaravelan : -- nosy: +inada.naoki ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue37206] Incorrect application of Argument Clinic to dict.pop()

New submission from Raymond Hettinger : help(dict.pop) was correct in 3.7: pop(...) D.pop(k[,d]) -> v and incorrect for 3.8: pop(self, key, default=None, /) This happened in: https://github.com/python/cpython/commit/9e4f2f3a6b8ee995c365e86d976937c141d867f8 https:/