[issue37124] test_msilib is potentially leaking references and memory blocks

STINNER Victor added the comment: I backported Pablo's fix to 2.7 and 3.7 to attempt to fix Windows Refleak 2.7 and Windows Refleak 3.7 buildbots. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <

[issue37124] test_msilib is potentially leaking references and memory blocks

STINNER Victor added the comment: New changeset 6cbff564f00fbe17b5443f6986a44ce116d32aee by Victor Stinner in branch '2.7': bpo-37124: Fix reference leak in test_msilib (GH-13750) (GH-14340) https://github.com/python/cpython/commit/6cbff564f00fbe17b5443f6986a44ce116d32aee -- __

[issue37124] test_msilib is potentially leaking references and memory blocks

miss-islington added the comment: New changeset c9015a7228029bb22fa581b31c4c1ebdc2882814 by Miss Islington (bot) in branch '3.7': bpo-37124: Fix reference leak in test_msilib (GH-13750) https://github.com/python/cpython/commit/c9015a7228029bb22fa581b31c4c1ebdc2882814 -- nosy: +miss-

[issue37124] test_msilib is potentially leaking references and memory blocks

Change by STINNER Victor : -- pull_requests: +14160 pull_request: https://github.com/python/cpython/pull/14340 ___ Python tracker ___ __

[issue37124] test_msilib is potentially leaking references and memory blocks

Change by miss-islington : -- pull_requests: +14159 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14339 ___ Python tracker ___ __

[issue37124] test_msilib is potentially leaking references and memory blocks

STINNER Victor added the comment: Python 2.7 is still affected: https://buildbot.python.org/all/#/builders/33/builds/607 test_msilib leaked [1, 1, 1] references, sum=3 -- nosy: +vstinner ___ Python tracker _

[issue37124] test_msilib is potentially leaking references and memory blocks

Steve Dower added the comment: I have no idea. I don't ever use msilib, but there are a few people who do that don't have any way to get bugs fixed, so I'll help merge. If it's just the test leak, probably it's in the test. I don't recall the change having any impact on resource usage. But a

[issue37124] test_msilib is potentially leaking references and memory blocks

Pablo Galindo Salgado added the comment: New changeset c0295dba259accc4b247beb22a0b2cc2f31d9850 by Pablo Galindo in branch 'master': bpo-37124: Fix reference leak in test_msilib (GH-13750) https://github.com/python/cpython/commit/c0295dba259accc4b247beb22a0b2cc2f31d9850 --

[issue37124] test_msilib is potentially leaking references and memory blocks

Pablo Galindo Salgado added the comment: The leak is because creating a 'msilib.Directory' adds an entry on a global variable '_directories', therefore leaking. My first PR will make sure the _directories is cleared out after the test to stop the leak, but it seems to me that the variable is

[issue37124] test_msilib is potentially leaking references and memory blocks

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +13631 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13750 ___ Python tracker __

[issue37124] test_msilib is potentially leaking references and memory blocks

Change by Pablo Galindo Salgado : -- nosy: +lukasz.langa priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailin

[issue37124] test_msilib is potentially leaking references and memory blocks

Pablo Galindo Salgado added the comment: This is likely to be caused by: https://github.com/python/cpython/pull/13688 -- ___ Python tracker ___ _

[issue37124] test_msilib is potentially leaking references and memory blocks

Change by Pablo Galindo Salgado : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue37124] test_msilib is potentially leaking references and memory blocks

New submission from Pablo Galindo Salgado : BUILDBOT FAILURE REPORT === Builder name: AMD64 Windows8.1 Refleaks 2.7 Builder url: https://buildbot.python.org/all/#/builders/33/ Build url: https://buildbot.python.org/all/#/builders/33/builds/604 Failed tests T