[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-24 Thread Steve Dower
Steve Dower added the comment: New changeset 6de4574c6393b9cf8d7dfb0dc6ce53ee5b9ea841 by Steve Dower in branch 'master': bpo-37023: Skip test_gdb under PGO (GH-13555) https://github.com/python/cpython/commit/6de4574c6393b9cf8d7dfb0dc6ce53ee5b9ea841 -- __

[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-24 Thread Steve Dower
Steve Dower added the comment: Test is now skipped if PGO was used. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-24 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +13466 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-24 Thread Steve Dower
Steve Dower added the comment: Okay, fixing the regex isn't an option, as most of the tests (just not the one copy-pasted above) rely on verifying the parameter value. I'll figure out how to skip the test on PGO build instead. -- ___ Python tracke

[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-23 Thread Steve Dower
Steve Dower added the comment: I confirmed earlier that removing the new code from builtins_id fixes this issue, which I suspect means that PGO is deciding to make different optimizations and produce different output. Other functions in the same stack also do not show their arguments, so I t

[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-23 Thread Steve Dower
Steve Dower added the comment: Well, the good news is I can repro it on a PGO build in WSL. So now I just need to go learn all about gcc's PGO build, debug info, and how gdb renders it! -- ___ Python tracker __

[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-23 Thread Steve Dower
Steve Dower added the comment: Ah no, it's expecting `builtin_id (self=..., v=...)` but getting `builtin_id ()` instead. -- ___ Python tracker ___ ___

[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-23 Thread Steve Dower
Steve Dower added the comment: Is it just expecting builtin_id() to have been inlined? That seems risky. -- nosy: +steve.dower ___ Python tracker ___ _

[issue37023] test_gdb failed on AMD64 Debian PGO 3.x

2019-05-23 Thread STINNER Victor
New submission from STINNER Victor : It's likely a regression caused by bpo-36842. https://buildbot.python.org/all/#/builders/47/builds/2854 Example of failure: == FAIL: test_NULL_ob_type (test.test_gdb.PrettyPrintTests) Ensu