[issue36993] zipfile: tuple IndexError on extract

Serhiy Storchaka added the comment: Thank you for your contribution Daniel. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker __

[issue36993] zipfile: tuple IndexError on extract

miss-islington added the comment: New changeset 3801b2699eb9441ca31c6ec8fa956fc0fe755ef7 by Miss Skeleton (bot) in branch '3.8': bpo-36993: Improve error reporting for zipfiles with bad zip64 extra data. (GH-14656) https://github.com/python/cpython/commit/3801b2699eb9441ca31c6ec8fa956fc0fe75

[issue36993] zipfile: tuple IndexError on extract

miss-islington added the comment: New changeset f7d50f8f997fbfce1556991a3700826536871fe7 by Miss Skeleton (bot) in branch '3.7': bpo-36993: Improve error reporting for zipfiles with bad zip64 extra data. (GH-14656) https://github.com/python/cpython/commit/f7d50f8f997fbfce1556991a370082653687

[issue36993] zipfile: tuple IndexError on extract

Change by miss-islington : -- pull_requests: +16505 pull_request: https://github.com/python/cpython/pull/16979 ___ Python tracker ___ __

[issue36993] zipfile: tuple IndexError on extract

Change by miss-islington : -- pull_requests: +16506 pull_request: https://github.com/python/cpython/pull/16980 ___ Python tracker ___ __

[issue36993] zipfile: tuple IndexError on extract

Serhiy Storchaka added the comment: New changeset da6ce58dd5ac109485af45878fca6bfd265b43e9 by Serhiy Storchaka (Daniel Hillier) in branch 'master': bpo-36993: Improve error reporting for zipfiles with bad zip64 extra data. (GH-14656) https://github.com/python/cpython/commit/da6ce58dd5ac10948

[issue36993] zipfile: tuple IndexError on extract

Daniel Hillier added the comment: I've pushed a PR which adds a test that generates corrupt zip64 files with different combinations of zip64 extra data lengths and zip64 flags (which determines how many fields are required in the extra data). It now raises a BadZipFile with a message naming

[issue36993] zipfile: tuple IndexError on extract

Change by Daniel Hillier : -- pull_requests: +14463 pull_request: https://github.com/python/cpython/pull/14656 ___ Python tracker ___ __

[issue36993] zipfile: tuple IndexError on extract

alter-bug-tracer added the comment: @berker.peksag, first of all sorry for the late reply. We are not sure that we know how to do that. Our tests are generated automatically. What we can do is retest the lib with your temporary fixes in place, to see if they fix all the problems our software

[issue36993] zipfile: tuple IndexError on extract

Berker Peksag added the comment: @alter-bug-tracer, could you please create test files for the cases Serhiy has just mentioned? -- ___ Python tracker ___

[issue36993] zipfile: tuple IndexError on extract

Serhiy Storchaka added the comment: It is not enough. IndexError can be raised for ln == 8 or 16 when file_size, compress_size and header_offset are all set to 0x. -- ___ Python tracker

[issue36993] zipfile: tuple IndexError on extract

Change by Berker Peksag : -- keywords: +patch pull_requests: +13611 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13727 ___ Python tracker ___

[issue36993] zipfile: tuple IndexError on extract

Berker Peksag added the comment: This report is valid. Serhiy has improved error reporting of the extra field in feccdb2a249a71be330765be77dee57121866779. counts can indeed be an empty tuple: elif ln == 0: counts = () If I'm reading section 4.5.3 of https://pkware.cachefly.net/

[issue36993] zipfile: tuple IndexError on extract

Stéphane Wirtel added the comment: unzip index_tuple.zip -x Archive: index_tuple.zip caution: zipfile comment truncated error [index_tuple.zip]: missing 3992977728 bytes in zipfile (attempting to process anyway) skipping: zipfile_extract/unsupported compression method 211 I th

[issue36993] zipfile: tuple IndexError on extract

New submission from alter-bug-tracer : The following code throws an IndexError when attempting to extract a malformed archive (attached): import zipfile import sys zf = zipfile.ZipFile(sys.argv[1]) for info in zf.infolist(): zf.extract(info.filename) Result: Traceback (most recent call las