[issue36970] Rename _PyObject_FastCallKeywords

2019-05-21 Thread Jeroen Demeyer
Change by Jeroen Demeyer : -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36970] Rename _PyObject_FastCallKeywords

2019-05-21 Thread Petr Viktorin
Petr Viktorin added the comment: If and when a function uses the vectorcall protocol (including the argument offset flag), it makes sense to rename it to vectorcall. Doing it before is misleading, IMO. Splitting fixes to unrelated issues (like bpo-36907) from PEP 590 is great, but this one

[issue36970] Rename _PyObject_FastCallKeywords

2019-05-21 Thread Jeroen Demeyer
Change by Jeroen Demeyer : -- title: Rename _PyObject_FastCall functions -> Rename _PyObject_FastCallKeywords ___ Python tracker ___ ___

[issue36970] Rename _PyObject_FastCallKeywords

2019-05-21 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue36970] Rename _PyObject_FastCallKeywords

2019-05-21 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: What's your opinion on renaming also _PyCFunction_FastCallKeywords -> _PyCFunction_Vectorcall _PyFunction_FastCallKeywords -> _PyFunction_Vectorcall If you agree, I will add it to the PR. -- ___ Python tracker