[issue36970] Rename _PyObject_FastCall functions

Jeroen Demeyer added the comment: The consensus on PEP 590 now seems to be to keep the name `_PyObject_FastCallDict` and rename only `_PyObject_FastCallKeywords` -> `_PyObject_Vectorcall`. For the record: I don't agree with this decision but I'll implement it. -- __

[issue36970] Rename _PyObject_FastCall functions

Stefan Krah added the comment: Also, thank you for lecturing a core dev again. -- nosy: +skrah ___ Python tracker ___ ___ Python-bu

[issue36970] Rename _PyObject_FastCall functions

Stefan Krah added the comment: Only people with very much time on their hands have the luxury to discuss changes like this on python-dev. -- ___ Python tracker ___ __

[issue36970] Rename _PyObject_FastCall functions

Change by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue36970] Rename _PyObject_FastCall functions

Change by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue36970] Rename _PyObject_FastCall functions

Jeroen Demeyer added the comment: > From the perspective of reading, it is one of the most obnoxious names I've > seen in the Python code base. PyObject_Vectorcall() is the name in PEP 590, so if you want to change it, better write to python-dev about it. -- ___

[issue36970] Rename _PyObject_FastCall functions

Stefan Krah added the comment: It is one thing to name something __vectorcall, and quite another to mix camel and normal case. When I'm scanning the code very quickly, I initially parse _PyObject_VectorcallDict as PyObject_VectorallDict or_PyObject_Vector_callDict. >From the perspective of

[issue36970] Rename _PyObject_FastCall functions

Jeroen Demeyer added the comment: > I would prefer to wait until the PEP is accepted before starting to push > changes ;-) I don't think it's wrong to propose and discuss changes already now. With the first beta of Python 3.8 getting close, it's better to be prepared already for the moment

[issue36970] Rename _PyObject_FastCall functions

Jeroen Demeyer added the comment: Now to justify the naming: the plan is to keep the name "fast call" for the PyMethodDef flag METH_FASTCALL but to use the name "vectorcall" in the more general API. I think that's a good idea regardless of PEP 590, as it makes it clear that _PyObject_Vector

[issue36970] Rename _PyObject_FastCall functions

Stefan Krah added the comment: > You think that "_PyObject_FastCallDict" is easier to read than > "_PyObject_VectorcallDict"? I don't think that there is much difference. Marvellous. How much do you work with the C-API? -- ___ Python tracker

[issue36970] Rename _PyObject_FastCall functions

Jeroen Demeyer added the comment: > Is it possible to rename Vectorcall, which looks good on its own but not > inside _PyObject_VectorcallDict()? I don't understand what you mean here? > _PyObject_FastCallDict is much easier to read. You think that "_PyObject_FastCallDict" is easier to read

[issue36970] Rename _PyObject_FastCall functions

STINNER Victor added the comment: > Has the PEP been accepted? It still says "Draft". I would prefer to wait until the PEP is accepted before starting to push changes ;-) -- Cython uses the FASTCALL calling convention. Please check with Stefan Behnel to see fix it's ok to "remove" _PyObjec

[issue36970] Rename _PyObject_FastCall functions

Stefan Krah added the comment: Sorry for the bikeshedding here, but I'll read those function names a lot. Is it possible to rename Vectorcall, which looks good on its own but not inside _PyObject_VectorcallDict()? _PyObject_FastCallDict is much easier to read. Has the PEP been accepted? It s

[issue36970] Rename _PyObject_FastCall functions

Change by Jeroen Demeyer : -- keywords: +patch pull_requests: +13347 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue36970] Rename _PyObject_FastCall functions

New submission from Jeroen Demeyer : As preparation for PEP 590, rename _PyObject_FastCallKeywords -> _PyObject_Vectorcall _PyObject_FastCallDict -> _PyObject_VectorcallDict -- components: Interpreter Core messages: 342892 nosy: Mark.Shannon, jdemeyer, petr.viktorin priority: normal se