[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- resolution: accepted -> fixed status: pending -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Henry Precheur <[EMAIL PROTECTED]> added the comment: I am now able to finish the build and the interpreter seems to be working. So it is all good :) ___ Python tracker <[EMAIL PROTECTED]>

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66187. Henry, could you confirm it fixes the problem on your side? -- priority: release blocker -> critical resolution: -> accepted status: open -> pending ___ Python tracker <[EMAIL

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Here is an updated patch: - changed #ifndef into #ifdef. The "broken" case comes first now. - check that the second call to mbstowcs does not fail. - also, changed an assert, since strlen() does not always count the exact number of chars

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Amaury, as long as you fix the small quirk mentioned above (checking the return value of the second call to mbstowcs()), I think this patch can go in, since it does no harm on already working platforms. ___

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > Yes; but here, the symbol (HAVE_BROKEN_MBSTOWC) has a negative meaning. > I tried to put the optimistic (=not broken) case first. > However, if this makes the code more difficult to read, I'll change it. You could change HAVE_BROKEN_MBSTOWC

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: > Another small remark; #ifdef is better then #ifndef > Simply because it easier to get "Be positive" than "Don't be negative". Yes; but here, the symbol (HAVE_BROKEN_MBSTOWC) has a negative meaning. I tried to put the optimistic (=not

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Henry Precheur <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11266/fix_mbstowcs_openbsd.diff ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Henry Precheur <[EMAIL PROTECTED]> added the comment: I removed my previous patch. It was not dealing with all broken mbstowcs cases and yours is much better. Some comments on the other patch: I don't think the macro HAVE_BROKEN_MBSTOWCS alone is a perfect idea. It won't fix the problem in the

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Mmh, in Modules/python.c and Python/frozenmain.c, the return value of the second call to mbstowcs() should be checked as well (since the first one is sometimes replaced by a call to strlen(), which never fails). __

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The patch looks fine and harmless to me (but I'm a configure newbie too). +1 for committing it and seeing if the OpenBSD buildbot feels better. In the process of testing this patch, I've found another bug: #3705. -- nosy: +pitrou __

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bu

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- priority: -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Pyt

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Here is another patch, which tries to replace all problematic usages of mbstowcs, and a new "#define HAVE_BROKEN_MBSTOWCS" to activate it. It needs a review, especially the "configure" stuff, it's my first time to deal with this. Teste

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: See also issue3626, which is exactly the same for cygwin. Maybe a "./configure" paragraph could discover whether mbstowcs is broken. I don't know how to do it though. -- nosy: +amaury.forgeotdarc __

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- title: mbstowcs -> Error parsing arguments on OpenBSD <= 4.4 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3696] Error parsing arguments on OpenBSD <= 4.4

New submission from Henry Precheur <[EMAIL PROTECTED]>: The function mbstowcs is buggy on OpenBSD <= 4.4: http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/locale/multibyte_sb.c#rev1.7 Because of this the following command fails: ./python -E setup.py build The attached patch fixes the problem.