[issue36948] NameError in urllib.request.URLopener.retrieve

Karthikeyan Singaravelan added the comment: Thank you David and Berker. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36948] NameError in urllib.request.URLopener.retrieve

Berker Peksag added the comment: Thanks! -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pytho

[issue36948] NameError in urllib.request.URLopener.retrieve

Berker Peksag added the comment: New changeset 2725cb01d7cbf5caecb51cc20d97ba324b09ce96 by Berker Peksag in branch 'master': bpo-36948: Fix test_urlopener_retrieve_file on Windows (GH-13476) https://github.com/python/cpython/commit/2725cb01d7cbf5caecb51cc20d97ba324b09ce96 -- __

[issue36948] NameError in urllib.request.URLopener.retrieve

David Bolen added the comment: Oh, and just for historical purposes, it looks like the root cause was that the nturl2path.pathnametourl forces an uppercase drive letter. So that's where the inconsistency in the test got introduced. -- ___ Python

[issue36948] NameError in urllib.request.URLopener.retrieve

David Bolen added the comment: Yes, PR 13476 tested locally on the Win10 builder resolves the error. -- ___ Python tracker ___ ___

[issue36948] NameError in urllib.request.URLopener.retrieve

Berker Peksag added the comment: Thank you for the heads up, David. Could you please take a look at PR 13476? -- ___ Python tracker ___ ___

[issue36948] NameError in urllib.request.URLopener.retrieve

Change by Berker Peksag : -- pull_requests: +13388 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list maili

[issue36948] NameError in urllib.request.URLopener.retrieve

Change by Berker Peksag : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36948] NameError in urllib.request.URLopener.retrieve

David Bolen added the comment: Since this patch was introduced to the 3.x branch my Windows 7 and 10 buildbots have been failing in test_urlopener_retrieve_file. See https://buildbot.python.org/all/#/builders/3/builds/2661 for the first such failure on the Win10 worker. The problem appears

[issue36948] NameError in urllib.request.URLopener.retrieve

Berker Peksag added the comment: Thanks! Apparently, backport to 3.7 isn't needed, so I just closed PR 13422. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue36948] NameError in urllib.request.URLopener.retrieve

Change by miss-islington : -- pull_requests: +13332 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36948] NameError in urllib.request.URLopener.retrieve

Berker Peksag added the comment: New changeset c661b30f89ffe7a7995538d3b1649469b184bee4 by Berker Peksag (Xtreak) in branch 'master': bpo-36948: Fix NameError in urllib.request.URLopener.retrieve (GH-13389) https://github.com/python/cpython/commit/c661b30f89ffe7a7995538d3b1649469b184bee4 --

[issue36948] NameError in urllib.request.URLopener.retrieve

Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +13297 stage: -> patch review ___ Python tracker ___ ___ Py

[issue36948] NameError in urllib.request.URLopener.retrieve

New submission from Karthikeyan Singaravelan : In issue27485 the deprecated functions were replaced with underscore prefixed ones due to which imports where modified. Some of the places where not changed causing NameError in using urllib.request.URLopener.retrieve for local files and non-loca