[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Petr Viktorin added the comment: New changeset d092caf096fa48baadfc0900792206bb5aa0192d by Petr Viktorin (Jeroen Demeyer) in branch '3.7': bpo-36907: fix refcount bug in _PyStack_UnpackDict() (GH-13381) (GH-13493) https://github.com/python/cpython/commit/d092caf096fa48baadfc0900792206bb5aa019

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Change by Jeroen Demeyer : -- pull_requests: +13408 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Jeroen Demeyer added the comment: Using __int__ instead of __index__ works. PR coming right away. -- ___ Python tracker ___ ___ Pyt

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Petr Viktorin added the comment: We do, but here the test will need to be changed: Python 3.7.3+ (heads/3.7:791e5fcbab, May 22 2019, 13:37:27) [GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> class IntWithDict: ...

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Jeroen Demeyer added the comment: > Jeroen, do you want to also do a backport for 3.7? Don't we have a bot for that? -- ___ Python tracker ___ ___

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Petr Viktorin added the comment: Jeroen, do you want to also do a backport for 3.7? -- ___ Python tracker ___ ___ Python-bugs-list

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Petr Viktorin added the comment: New changeset 77aa396bb9415428de09112ddf6b34bb843811eb by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36907: fix refcount bug in _PyStack_UnpackDict() (GH-13381) https://github.com/python/cpython/commit/77aa396bb9415428de09112ddf6b34bb843811eb ---

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Change by Jeroen Demeyer : -- pull_requests: +13292 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Change by Jeroen Demeyer : -- keywords: +patch pull_requests: +13217 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Jeroen Demeyer added the comment: The idea of #36904 could be used here: define a special kind of tuple, which is like an ordinary tuple followed by a C array of PyObject* entries (all refcounted), terminated by a NULL to know where it ends. A special deallocation function would decref all e

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Jeroen Demeyer added the comment: Ideally, this would be fixed together with #36904. -- ___ Python tracker ___ ___ Python-bugs-list

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

Change by Jeroen Demeyer : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

New submission from Jeroen Demeyer : class IntWithDict: def __init__(self, **kwargs): self.kwargs = kwargs def __index__(self): self.kwargs.clear() L = [2**i for i in range(1)] return 0 x = IntWithDict(dont_inherit=float()) compile("", "", "", x, **x.k