[issue36831] ElementTree.find attribute matching with empty namespace

2019-05-08 Thread Stefan Behnel
Change by Stefan Behnel : -- stage: needs patch -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue36831] ElementTree.find attribute matching with empty namespace

2019-05-08 Thread Stefan Behnel
Stefan Behnel added the comment: Sorry for the annoyance during the release. -- keywords: -patch resolution: -> fixed stage: patch review -> needs patch status: open -> closed ___ Python tracker __

[issue36831] ElementTree.find attribute matching with empty namespace

2019-05-08 Thread Stefan Behnel
Stefan Behnel added the comment: New changeset 88db8bd0648588c67eeab16d0bc72ec5c206e3ad by Stefan Behnel in branch 'master': bpo-36831: Do not apply default namespace to unprefixed attributes in ElementPath. (#13201) https://github.com/python/cpython/commit/88db8bd0648588c67eeab16d0bc72ec5c2

[issue36831] ElementTree.find attribute matching with empty namespace

2019-05-08 Thread Stefan Behnel
Change by Stefan Behnel : -- keywords: +patch pull_requests: +13112 stage: needs patch -> patch review ___ Python tracker ___ ___ Py

[issue36831] ElementTree.find attribute matching with empty namespace

2019-05-08 Thread Stefan Behnel
Stefan Behnel added the comment: Right, thanks for the reproducer. The default namespace should not apply to attributes. I'll write up a PR today. -- ___ Python tracker ___ _

[issue36831] ElementTree.find attribute matching with empty namespace

2019-05-07 Thread Steve Dower
Steve Dower added the comment: Here is a test case that fails on 3.8.0a4 and succeeds on 3.7.3: def test_find_attribute_with_empty_ns(self): NS = "http://effbot.org/ns"; element = ET.fromstring(f"") self.assertIsNotNone(element.find("t:section[@id='1']", {"":NS,

[issue36831] ElementTree.find attribute matching with empty namespace

2019-05-07 Thread Steve Dower
New submission from Steve Dower : I suspect this is related to the fix for issue30485, but haven't fully debugged it. In PC/layout/support/appxmanifest.py, I have code that looks up an existing element and adds it if missing: def find_or_add(xml, element, attr=None, always_add=False): if