[issue36824] Refactor str tests to reflect that str and unicode are merged in Python 3

2019-05-07 Thread Daniel Fortunov
Change by Daniel Fortunov : -- keywords: +patch pull_requests: +13088 stage: -> patch review ___ Python tracker ___ ___ Python-bugs

[issue36824] Refactor str tests to reflect that str and unicode are merged in Python 3

2019-05-07 Thread Daniel Fortunov
Daniel Fortunov added the comment: PS opened here: https://github.com/python/cpython/pull/13172 I've tried to break down the changes into individual steps, with justification in commit messages. Happy to collapse these down into fewer commits before merge if preferred. I haven't done the "Pr

[issue36824] Refactor str tests to reflect that str and unicode are merged in Python 3

2019-05-07 Thread Daniel Fortunov
Daniel Fortunov added the comment: Agreed. This functionality is in `BaseTest` (which is the base for `CommonTest`) and I don't propose to change this. -- ___ Python tracker

[issue36824] Refactor str tests to reflect that str and unicode are merged in Python 3

2019-05-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is still the functionality common to str, bytes and bytearray. So it make sense to have the common class for testing str, bytes, bytearray and UserList and other common class (subclass of the former one) for testing str and UserList. -- nosy

[issue36824] Refactor str tests to reflect that str and unicode are merged in Python 3

2019-05-06 Thread SilentGhost
Change by SilentGhost : -- components: +Tests -Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36824] Refactor str tests to reflect that str and unicode are merged in Python 3

2019-05-06 Thread Daniel Fortunov
New submission from Daniel Fortunov : Unit tests of `str` and related types (e.g. `UserString`) contain nomenclature and structure that dates back to the Python 2 distinction between `str` and `unicode`. Previously it was undesirable to disturb the structure of these tests too much as this w