[issue3677] importing from UNC roots doesn't work

Hirokazu Yamamoto added the comment: Ah, "es" is used in py3k, thanks. And sorry about my merge which had memory leak. ___ Python tracker ___

[issue3677] importing from UNC roots doesn't work

Martin v. Löwis added the comment: > Sorry if I'm missing something, but is this really needed? Yes, the "es" converter allocates memory. ___ Python tracker ___ _

[issue3677] importing from UNC roots doesn't work

Hirokazu Yamamoto added the comment: >The path variable should be PyMem_Free'd Sorry if I'm missing something, but is this really needed? Other PyArg_ParseTuple(args, "s... doesn't seem to have corresponding PyMem_Free. static PyObject * imp_new_module(PyObject *self, PyObject *args) {

[issue3677] importing from UNC roots doesn't work

Kristján Valur Jónsson added the comment: Added tests for UNC path imports in r68883 and r68884 ___ Python tracker ___ ___ Python-bugs-list mai

[issue3677] importing from UNC roots doesn't work

Kristján Valur Jónsson added the comment: added the mem release in r68882. I'll try to add test cases too. ___ Python tracker ___ ___ Python-bu

[issue3677] importing from UNC roots doesn't work

Gabriel Genellina added the comment: The path variable should be PyMem_Free'd (in both trunk and py3k) (also, I don't see any specific test - is there any?) -- nosy: +gagenellina ___ Python tracker

[issue3677] importing from UNC roots doesn't work

Hirokazu Yamamoto added the comment: Merged in r68873(py3k). ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue3677] importing from UNC roots doesn't work

Benjamin Peterson added the comment: This fix needs to be ported to the py3k branch. Can somebody please do it? -- nosy: +benjamin.peterson ___ Python tracker ___ ___

[issue3677] importing from UNC roots doesn't work

Kristján Valur Jónsson added the comment: Checked in as revision: 68457 -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue3677] importing from UNC roots doesn't work

Kristján Valur Jónsson added the comment: Okay, I've tested the patch and made some beauty fixes. Can we have this in, please? Added file: http://bugs.python.org/file12591/not_use_stat_in_import_on_windows.patch ___ Python tracker

[issue3677] importing from UNC roots doesn't work

Changes by Hirokazu Yamamoto <[EMAIL PROTECTED]>: -- components: +Windows ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-lis

[issue3677] importing from UNC roots doesn't work

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment: Just humble thought... If we can replace stat(2) + S_ISDIR/S_ISREG check with GetFileAttributesEx, maybe we are safe for this kind of problem, and can solve issue3099 same time? :-) ___ Python tracker <[

[issue3677] importing from UNC roots doesn't work

Changes by Hirokazu Yamamoto <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11740/not_use_stat_in_import_on_windows.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3677] importing from UNC roots doesn't work

Changes by Hirokazu Yamamoto <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11739/not_use_stat_in_import_on_windows.patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3677] importing from UNC roots doesn't work

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment: zipimport.c seems fine, because stat(2) succeeds for UNC file. It fails for UNC folder. (zip file is absolutely file) Already fix for issue1293 was in, so maybe I should create the patch for that direction but... anyway this issue seems to

[issue3677] importing from UNC roots doesn't work

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment: Ah, of cource, please change path to fit you environment. > test prog ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3677] importing from UNC roots doesn't work

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment: I think this is stat(2) problem on windows. Please try following test program. #include #include #include void test(const char *path) { struct stat st; printf("%s %d %d\n", path, stat(path, &st), GetFileAttributes(path)); } i

[issue3677] importing from UNC roots doesn't work

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Ok, un-targetting this from 2.5.3 then. Usage of IsUNCRoot disappeared as part of r42230, which dropped usage of the C library for stat implementations. This only affects os.stat, though, so I don't see the relation to this issue. For the

[issue3677] importing from UNC roots doesn't work

Kristján Valur Jónsson <[EMAIL PROTECTED]> added the comment: No, not really. Again, I refer to defect 954115 by glchapman. And note that those functions added there are actually not used. I was hoping that there was someone here more familiar with importing on PC. I'll go and see if the old d

[issue3677] importing from UNC roots doesn't work

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Kristjan, you suggested this issue for consideration for 2.5.3. Is there an actual patch to apply? If not, the issue should get forwarded to 2.7 (and then to 2.8, and so on, until somebody actually comes up with a patch). -- nosy:

[issue3677] importing from UNC roots doesn't work

Kristján Valur Jónsson <[EMAIL PROTECTED]> added the comment: Correction: The workaround is to _append_ a backslash. ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3677] importing from UNC roots doesn't work

New submission from Kristján Valur Jónsson <[EMAIL PROTECTED]>: When executing a script from a UNC path, e.g. //myhost/exports/a.py, r"\\myhost\exports" gets prepended to sys.path. But it doesn't work. This means that in a.py, "import b" will fail even though b.py is present in the same dire