[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Ned Deily added the comment: New changeset fd1771dbdd28709716bd531580c40ae5ed814468 by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) https://github.com/python/cpython/commit/fd1771dbdd28709716bd531580c40ae

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Steve Dower added the comment: New changeset f61599b050c621386a3fc6bc480359e2d3bb93de by Steve Dower in branch '2.7': bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) https://github.com/python/cpython/commit/f61599b050c621386a3fc6bc480359e2d3bb93de -- ___

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

miss-islington added the comment: New changeset 250b62acc59921d399f0db47db3b462cd6037e09 by Miss Islington (bot) in branch '3.7': bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) https://github.com/python/cpython/commit/250b62acc59921d399f0db47db3b462cd6037e09 ---

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Senthil Kumaran added the comment: Thanks for this engagement and pull requests, Steve. Thanks for reviews Karthikeyan. -- nosy: +orsenthil ___ Python tracker ___

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by Steve Dower : -- pull_requests: +13701 pull_request: https://github.com/python/cpython/pull/13815 ___ Python tracker ___ _

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by miss-islington : -- pull_requests: +13700 pull_request: https://github.com/python/cpython/pull/13814 ___ Python tracker ___ __

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Łukasz Langa added the comment: New changeset 8d0ef0b5edeae52960c7ed05ae8a12388324f87e by Łukasz Langa (Steve Dower) in branch 'master': bpo-36742: Corrects fix to handle decomposition in usernames (#13812) https://github.com/python/cpython/commit/8d0ef0b5edeae52960c7ed05ae8a12388324f87e ---

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by miss-islington : -- pull_requests: +13699 pull_request: https://github.com/python/cpython/pull/13813 ___ Python tracker ___ __

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by Steve Dower : -- pull_requests: +13698 pull_request: https://github.com/python/cpython/pull/13812 ___ Python tracker ___ _

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Ned Deily added the comment: New changeset e5f9f4adb95233c66578e6f7ea176687af2f78ca by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-36742: Fixes handling of pre-normalization characters in urlsplit() (GH-13017) (GH-13024) https://github.com/python/cpython/commit/e5f9f4adb95233c66578

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by Steve Dower : -- pull_requests: +12961 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Steve Dower added the comment: Yes, you're right. I'll do that port as well. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Karthikeyan Singaravelan added the comment: > I'll leave the 3.6 backport in Ned's hands and close this issue. 3.5 was added as an affected version and seems the original fix was merged to 3.5 too. 3.4 is EoL so is it worthy of backporting to 3.5? I guess the backport would not have merge co

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Steve Dower added the comment: I'll leave the 3.6 backport in Ned's hands and close this issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Steve Dower added the comment: New changeset 98a4dcefbbc3bce5ab07e7c0830a183157250259 by Steve Dower in branch '2.7': bpo-36742: Fixes handling of pre-normalization characters in urlsplit() (GH-13017) https://github.com/python/cpython/commit/98a4dcefbbc3bce5ab07e7c0830a183157250259 ---

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Chihiro Ito added the comment: I have confirmed that all of my app's test cases have passed. What I've done: 1. Installed Python 3.7.3. 2. Replaced urllib/parse.py with the one from 781ffb1. 3. Ran my app's test cases. Thank you for the quick fix! --

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

miss-islington added the comment: New changeset 4d723e76e1ad17e9e7d5e828e59bb47e76f2174b by Miss Islington (bot) in branch '3.7': bpo-36742: Fixes handling of pre-normalization characters in urlsplit() (GH-13017) https://github.com/python/cpython/commit/4d723e76e1ad17e9e7d5e828e59bb47e76f217

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by Steve Dower : -- pull_requests: +12947 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by miss-islington : -- pull_requests: +12946 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Steve Dower added the comment: New changeset d537ab0ff9767ef024f26246899728f0116b1ec3 by Steve Dower in branch 'master': bpo-36742: Fixes handling of pre-normalization characters in urlsplit() (GH-13017) https://github.com/python/cpython/commit/d537ab0ff9767ef024f26246899728f0116b1ec3

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by miss-islington : -- pull_requests: +12945 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Steve Dower added the comment: I found the time to get the first patch. Hopefully backports to 3.6 and 3.7 are easy, but I think 2.7 will take manual steps. Chihiro Ito - if you have other test scenarios, it would be great if you could try them out with the fix in PR 13017. It should be easy

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by Steve Dower : -- keywords: +patch pull_requests: +12940 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Steve Dower added the comment: Yes, it's due to that. I guess we need to do netloc.rpartition(':') like we currently do for '@' in _checknetloc. Promoting to release blocker and security issue to match the original issue. I can't get to this today, but I should be able to at the PyCon sprint

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Karthikeyan Singaravelan added the comment: This could be due to issue36216. -- nosy: +steve.dower, xtreak ___ Python tracker ___ _

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

New submission from Chihiro Ito : urllib.parse.urlsplit raises an exception for an url including a non-ascii hostname in NFKD form and a port number. example: >>> urlsplit('http://\u30d5\u309a:80') Traceback (most recent call last): File "", line 1, in File "/Users/ito/.maltybrew/deen/lib/

[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

Change by Chihiro Ito : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py