[issue36688] _dummy_thread lacks an RLock implementaiton

STINNER Victor added the comment: Thanks Joost Lek for the fix and Karthikeyan Singaravelan for the bug report. It's now fixed in 3.7, 3.8 and master branches. I close the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue36688] _dummy_thread lacks an RLock implementaiton

miss-islington added the comment: New changeset ad505918a1829e6fa2a48a7665234d60a9377e98 by Miss Islington (bot) in branch '3.8': bpo-36688: Adding an implementation of RLock in _dummy_thread (GH-12943) https://github.com/python/cpython/commit/ad505918a1829e6fa2a48a7665234d60a9377e98 --

[issue36688] _dummy_thread lacks an RLock implementaiton

miss-islington added the comment: New changeset 351b0e793e35510e8cbbcbb455a1b9544e808cdd by Miss Islington (bot) in branch '3.7': bpo-36688: Adding an implementation of RLock in _dummy_thread (GH-12943) https://github.com/python/cpython/commit/351b0e793e35510e8cbbcbb455a1b9544e808cdd --

[issue36688] _dummy_thread lacks an RLock implementaiton

STINNER Victor added the comment: > Ping. This was marked as a 3.7regression and there is a PR waiting for > review. PR 12943 seems reasonable to me. I merged it. > Do we have plans to remove _dummy_thread in 3.8 or 3.9? I created bpo-37312 for Python 3.9. IMHO it's too late for 3.8.

[issue36688] _dummy_thread lacks an RLock implementaiton

Change by miss-islington : -- pull_requests: +13986 pull_request: https://github.com/python/cpython/pull/14145 ___ Python tracker ___ __

[issue36688] _dummy_thread lacks an RLock implementaiton

STINNER Victor added the comment: New changeset c5905f39bcf4ef895d42eede41bb5a2f071a501d by Victor Stinner (Joost Lek) in branch 'master': bpo-36688: Adding an implementation of RLock in _dummy_thread (GH-12943) https://github.com/python/cpython/commit/c5905f39bcf4ef895d42eede41bb5a2f071a501d

[issue36688] _dummy_thread lacks an RLock implementaiton

Change by miss-islington : -- pull_requests: +13985 pull_request: https://github.com/python/cpython/pull/14144 ___ Python tracker ___ __

[issue36688] _dummy_thread lacks an RLock implementaiton

STINNER Victor added the comment: I created bpo-37312: "Remove deprecated _dummy_thread and dummy_threading modules" (in Python 3.9). -- nosy: +vstinner ___ Python tracker __

[issue36688] _dummy_thread lacks an RLock implementaiton

Ned Deily added the comment: Ping. This was marked as a 3.7regression and there is a PR waiting for review. Do we have plans to remove _dummy_thread in 3.8 or 3.9? -- nosy: +ned.deily versions: +Python 3.9 ___ Python tracker

[issue36688] _dummy_thread lacks an RLock implementaiton

Change by Roundup Robot : -- keywords: +patch pull_requests: +12867 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue36688] _dummy_thread lacks an RLock implementaiton

Brett Cannon added the comment: Basically _thread.RLock was added without an equivalent in _dummy_thread. Add that and it will fix the issue. It probably wouldn't be too hard since you have to implement it as if it's single-threaded and there's already a lock class in _dummy_thread to work o