[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

STINNER Victor added the comment: New changeset 4fb15021890d327023aefd95f5a84ac33b037d19 by Victor Stinner (Lihua Zhao) in branch 'master': bpo-36648: fix mmap issue for VxWorks (GH-12394) https://github.com/python/cpython/commit/4fb15021890d327023aefd95f5a84ac33b037d19 --

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

LihuaZhao added the comment: >>What is the current behavior of m = mmap.mmap(-1, 100)? Does it raise an >>exception? No, the following statement will return -1 without PR 12394 m_obj->data = mmap(NULL, map_size, prot, flags, fd, offset); >>I

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

STINNER Victor added the comment: I don't understand why PR 12394 modifies flags afterwards, whereas "m = mmap.mmap(-1, 100)" doesn't specify explicitly flags. So the bug looks to be default flags set by Python, no? int flags = MAP_SHARED; ... if (!PyArg_ParseTupleAndKeywords(ar

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

STINNER Victor added the comment: What is the current behavior of m = mmap.mmap(-1, 100)? Does it raise an exception? -- ___ Python tracker ___ __

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

Change by LihuaZhao : -- pull_requests: -12788 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

Change by LihuaZhao : -- keywords: +patch pull_requests: +12788 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

Change by LihuaZhao : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

Change by LihuaZhao : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue36648] MAP_SHARED isn't proper for anonymous mappings for VxWorks

New submission from LihuaZhao : anonymous mappings is not part of the POSIX standard, python user just need to specified -1 as fd value when do anonymous map, for example: m = mmap.mmap(-1, 100) then python adapter module(mmapmodule.c) try to specify MAP_SHARED or MAP_PRIVATE based on operat