[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Current status: test_distutils leaked [141, 142] references, sum=283 test_logging leaked [0, -219] references, sum=-219 test_smtplib leaked [0, 87] references, sum=87 The distutils leak should be investigated, but the overall situation is ra

[issue3660] reference leaks in 3.0

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: encode-leak3.patch applied in r66234. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Amaury, your patch is much clearer indeed and it fixes the leak. -- keywords: -needs review ___ Python tracker <[EMAIL PROTECTED]> __

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Le vendredi 05 septembre 2008 à 13:08 +, Amaury Forgeot d'Arc a écrit : > Antoine, it seem that with encode-leak2.patch, the error path after > PyErr_WarnEx() leaks the value of "v". Hmm, you are right. > I rewrote the whole paragraph to

[issue3660] reference leaks in 3.0

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Antoine, it seem that with encode-leak2.patch, the error path after PyErr_WarnEx() leaks the value of "v". I rewrote the whole paragraph to make it more straightforward: - the normal case is tested first - all paths end with a "return",

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: FWIW, applying encode-leak2.patch removes the leak in test_unicode. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3660] reference leaks in 3.0

Neal Norwitz <[EMAIL PROTECTED]> added the comment: The only one that is probably an issue based on Antoine's info is: test_unicode leaked [1, 1] references, sum=2 I've seen test_urllib2_localnet leak 3 before. I don't know that it's a real leak. I'm pretty sure it is not a regression though.

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Numbers for the current py3k branch (without encode-leak2.patch): test_distutils leaked [141, 142] references, sum=283 test_docxmlrpc leaked [-7, -85] references, sum=-92 test_logging leaked [0, 219] references, sum=219 test_poplib leaked [0,

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The patch for _pickle has been committed in r66227. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3660] reference leaks in 3.0

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-lis

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, after the two patches plus the patch in #3667, I get the following: test_asyncore leaked [84, -84] references, sum=0 test_distutils leaked [141, 142] references, sum=283 test_docxmlrpc leaked [-85, 0] references, sum=-85 test_logging leak

[issue3660] reference leaks in 3.0

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Did you look at the patch for issue3667 ? it should at least correct test_site. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: With the two patches applied, we are now at: test_unittest leaked [124, 124] references, sum=248 test_distutils leaked [141, 142] references, sum=283 test_docxmlrpc leaked [85, -85] references, sum=0 test_logging leaked [366, -366] references

[issue3660] reference leaks in 3.0

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11285/encode-leak.patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3660] reference leaks in 3.0

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Oops, you are right of course. I remove my patch so we don't get confused. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Amaury, I believe the first part of encode-leak.patch is wrong, you should Py_DECREF the bytearray after it has been converted to bytes, not before. Here is an alternate patch. Added file: http://bugs.python.org/file11309/encode-leak2.patch

[issue3660] reference leaks in 3.0

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: the leaks in test_pickle and test_pickletools are corrected by the attached patch. Added file: http://bugs.python.org/file11288/pickle-leak.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3660] reference leaks in 3.0

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: issue3712 tracks the memoryview issues. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > str(memoryview(b'character buffers are decoded to unicode'), 'utf-8') > I tried another patch, but I'm not sure: I get lost between all these > buffers... a Py_DECREF(self->view.obj) in memory_releasebuf() seems to work. Could you open a

[issue3660] reference leaks in 3.0

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: - the "test_site leaked [88, 88]" is the same as problem as issue3667. - test_unicodes leaks in PyUnicode_AsEncodedString (attached patch), and also with: str(memoryview(b'character buffers are decoded to unicode'), 'utf-8') I tried a

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: As of r66047, I get the following results (without "-uall", though): test_unittest leaked [124, 124] references, sum=248 test_binascii leaked [1, 1] references, sum=2 test_distutils leaked [141, 142] references, sum=283 test_logging leaked [2

[issue3660] reference leaks in 3.0

New submission from Neal Norwitz <[EMAIL PROTECTED]>: Even after adding the current patch in http://bugs.python.org/issue3651 there are many reference leaks. This bug can be a placeholder for all the reference leaks returned from: ./python ./Lib/test/regrtest.py -R 3:2 -uall,-bsddb The cur