[issue3643] Add more checks to testcapi

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Fair enough. Fixed in r66000 (trunk) and r66001 (py3k). -- resolution: -> fixed status: open -> closed versions: +Python 2.6, Python 3.0 -Python 2.7, Python 3.1 ___ Python tracker <[EMAIL PROTE

[issue3643] Add more checks to testcapi

Georg Brandl <[EMAIL PROTECTED]> added the comment: Still, _testcapi is built even for non-debug builds, so it is a gratuitous way for bad code to crash or internally invalidate a Python interpreter, so this should be treated like a bugfix. -- nosy: +georg.brandl priority: normal -> high

[issue3643] Add more checks to testcapi

STINNER Victor <[EMAIL PROTECTED]> added the comment: @pitrou: This issue is not critical. It's not a bug, it's an enhancement since _testcapi :-) ___ Python tracker <[EMAIL PROTECTED]> __

[issue3643] Add more checks to testcapi

Changes by Daniel Diniz <[EMAIL PROTECTED]>: -- nosy: +ajaksu2 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing l

[issue3643] Add more checks to testcapi

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Ok. I'll apply your patches when we get to 2.7. Do ping me if a forget, though. -- assignee: -> benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> _

[issue3643] Add more checks to testcapi

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Unless someone thinks it's somehow release-critical, I'm retargetting this to 2.7/3.1. -- nosy: +pitrou versions: +Python 2.7, Python 3.1 -Python 2.6, Python 3.0 ___ Python tracker <[EMAIL PROTECTE

[issue3643] Add more checks to testcapi

STINNER Victor <[EMAIL PROTECTED]> added the comment: @benjamin.peterson: I know but the module (installed in CPython default installation) is for testing purpose only, but invalid uses of its method would lead to inconsistent CPython internal state and that's bad :-) If you tried to say that

[issue3643] Add more checks to testcapi

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Your patches are pretty harmless, but this module is just for testing purposes. -- nosy: +benjamin.peterson priority: -> normal ___ Python tracker <[EMAIL PROTECTED]>

[issue3643] Add more checks to testcapi

STINNER Victor <[EMAIL PROTECTED]> added the comment: Python 3.0 has an new function which requires an extra patch: exception_print() have to check that the argument is an exception instance: >>> import _testcapi >>> _testcapi.exception_print(10) Erreur de segmentation (core dumped)

[issue3643] Add more checks to testcapi

New submission from STINNER Victor <[EMAIL PROTECTED]>: test_thread_state() doesn't check that the argument is a function and doesn't check function call result and so the exception is catched later: Non callable argument: import _testcapi _testcapi._test_thread_state(10) # no excepti